From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 21/26] qapi: Command returning anonymous type doesn't work, outlaw
Date: Wed, 5 Aug 2015 08:22:33 -0600 [thread overview]
Message-ID: <55C21C29.5050404@redhat.com> (raw)
In-Reply-To: <871tfiwbfc.fsf@blackfin.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
On 08/04/2015 11:29 PM, Markus Armbruster wrote:
> Eric Blake <eblake@redhat.com> writes:
>
>> On 08/04/2015 03:18 AM, Markus Armbruster wrote:
>>> Reproducer: with
>>>
>>> { 'command': 'user_def_cmd4', 'returns': { 'a': 'int' } }
>>>
>>> added to qapi-schema-test.json, qapi-commands.py dies when it tries to
>>> generate the command handler function
>>>
>> +++ w/tests/qapi-schema/command-int.json
>> @@ -1,3 +1,4 @@
>> # we reject collisions between commands and types
>> { 'command': 'int', 'data': { 'character': 'str' },
>> - 'returns': { 'value': 'int' } }
>> + 'returns': 'Foo' }
>> +{ 'struct': 'Foo', 'data': { 'value': 'int' } }
>
> Okay to simply drop the 'returns' instead?
>
Sure, that works too.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-08-05 14:22 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 9:17 [Qemu-devel] [PATCH 00/26] qapi: Another round of fixes and cleanups Markus Armbruster
2015-08-04 9:17 ` [Qemu-devel] [PATCH 01/26] qapi: Clarify docs on including the same file multiple times Markus Armbruster
2015-08-04 9:17 ` [Qemu-devel] [PATCH 02/26] qapi: Clean up cgen() and mcgen() Markus Armbruster
2015-08-04 15:44 ` Markus Armbruster
2015-08-04 16:33 ` Eric Blake
2015-08-04 9:17 ` [Qemu-devel] [PATCH 03/26] qapi: Simplify guardname() Markus Armbruster
2015-08-04 9:17 ` [Qemu-devel] [PATCH 04/26] qapi-event: Clean up how name of enum QAPIEvent is made Markus Armbruster
2015-08-04 9:17 ` [Qemu-devel] [PATCH 05/26] qapi: Reject -p arguments that break qapi-event.py Markus Armbruster
2015-08-04 9:17 ` [Qemu-devel] [PATCH 06/26] qapi: Drop unused and useless parameters and variables Markus Armbruster
2015-08-04 9:17 ` [Qemu-devel] [PATCH 07/26] qapi: Fix generated code when flat union has member 'kind' Markus Armbruster
2015-08-04 16:17 ` Eric Blake
2015-08-05 5:24 ` Markus Armbruster
2015-08-04 9:17 ` [Qemu-devel] [PATCH 08/26] qapi: Generate a nicer struct for flat unions Markus Armbruster
2015-08-04 17:00 ` Eric Blake
2015-08-04 9:17 ` [Qemu-devel] [PATCH 09/26] qapi-visit: Fix generated code when schema has forward refs Markus Armbruster
2015-08-04 9:18 ` [Qemu-devel] [PATCH 10/26] qapi-visit: Replace list implicit_structs by set Markus Armbruster
2015-08-04 9:18 ` [Qemu-devel] [PATCH 11/26] qapi-visit: Fix two name arguments passed to visitors Markus Armbruster
2015-08-04 9:18 ` [Qemu-devel] [PATCH 12/26] tests/qapi-schema: Document alternate's enum lacks visit function Markus Armbruster
2015-08-04 9:18 ` [Qemu-devel] [PATCH 13/26] tests/qapi-schema: Document events with base don't work Markus Armbruster
2015-08-04 9:18 ` [Qemu-devel] [PATCH 14/26] qapi: Document that input visitor semantics are prone to leaks Markus Armbruster
2015-08-04 9:18 ` [Qemu-devel] [PATCH 15/26] qapi: Document shortcoming with union 'data' branch Markus Armbruster
2015-08-04 9:18 ` [Qemu-devel] [PATCH 16/26] qapi: Document flaws in checking of names Markus Armbruster
2015-08-04 17:29 ` Eric Blake
2015-08-04 9:18 ` [Qemu-devel] [PATCH 17/26] tests/qapi-schema: Restore test case for flat union base bug Markus Armbruster
2015-08-04 9:18 ` [Qemu-devel] [PATCH 18/26] tests/qapi-schema: Rename tests from data- to args- Markus Armbruster
2015-08-04 17:37 ` Eric Blake
2015-08-04 9:18 ` [Qemu-devel] [PATCH 19/26] qapi-tests: New tests for union, alternate command arguments Markus Armbruster
2015-08-04 9:18 ` [Qemu-devel] [PATCH 20/26] qapi: Fix to reject union command and event arguments Markus Armbruster
2015-08-04 17:44 ` Eric Blake
2015-08-17 19:14 ` Eric Blake
2015-08-24 11:17 ` Markus Armbruster
2015-08-04 9:18 ` [Qemu-devel] [PATCH 21/26] qapi: Command returning anonymous type doesn't work, outlaw Markus Armbruster
2015-08-04 18:03 ` Eric Blake
2015-08-05 5:29 ` Markus Armbruster
2015-08-05 14:22 ` Eric Blake [this message]
2015-08-06 5:43 ` Markus Armbruster
2015-08-04 9:18 ` [Qemu-devel] [PATCH 22/26] qapi-commands: Fix gen_err_check(e) for e and e != 'local_err' Markus Armbruster
2015-08-04 9:18 ` [Qemu-devel] [PATCH 23/26] qapi-commands: Inline gen_marshal_output_call() Markus Armbruster
2015-08-04 9:18 ` [Qemu-devel] [PATCH 24/26] qapi-commands: Don't feed output of mcgen() to mcgen() again Markus Armbruster
2015-08-04 9:18 ` [Qemu-devel] [PATCH 25/26] qapi-commands: Drop useless initialization Markus Armbruster
2015-08-04 18:46 ` Eric Blake
2015-08-04 9:18 ` [Qemu-devel] [PATCH 26/26] qapi: Generated code cleanup Markus Armbruster
2015-08-04 18:59 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C21C29.5050404@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).