From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55174)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZMzae-0000H3-JV
	for qemu-devel@nongnu.org; Wed, 05 Aug 2015 10:22:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZMzaZ-0006B1-Pu
	for qemu-devel@nongnu.org; Wed, 05 Aug 2015 10:22:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53395)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZMzaZ-0006Ax-Jt
	for qemu-devel@nongnu.org; Wed, 05 Aug 2015 10:22:39 -0400
References: <1438679896-5077-1-git-send-email-armbru@redhat.com>
	<1438679896-5077-22-git-send-email-armbru@redhat.com>
	<55C0FE8A.9040000@redhat.com> <871tfiwbfc.fsf@blackfin.pond.sub.org>
From: Eric Blake <eblake@redhat.com>
Message-ID: <55C21C29.5050404@redhat.com>
Date: Wed, 5 Aug 2015 08:22:33 -0600
MIME-Version: 1.0
In-Reply-To: <871tfiwbfc.fsf@blackfin.pond.sub.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="pNJtTherEB66E1FQOGJCU7P5mkBeI4aFJ"
Subject: Re: [Qemu-devel] [PATCH 21/26] qapi: Command returning anonymous
 type doesn't work, outlaw
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--pNJtTherEB66E1FQOGJCU7P5mkBeI4aFJ
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 08/04/2015 11:29 PM, Markus Armbruster wrote:
> Eric Blake <eblake@redhat.com> writes:
>=20
>> On 08/04/2015 03:18 AM, Markus Armbruster wrote:
>>> Reproducer: with
>>>
>>>     { 'command': 'user_def_cmd4', 'returns': { 'a': 'int' } }
>>>
>>> added to qapi-schema-test.json, qapi-commands.py dies when it tries t=
o
>>> generate the command handler function
>>>

>> +++ w/tests/qapi-schema/command-int.json
>> @@ -1,3 +1,4 @@
>>  # we reject collisions between commands and types
>>  { 'command': 'int', 'data': { 'character': 'str' },
>> -  'returns': { 'value': 'int' } }
>> +  'returns': 'Foo' }
>> +{ 'struct': 'Foo', 'data': { 'value': 'int' } }
>=20
> Okay to simply drop the 'returns' instead?
>=20

Sure, that works too.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--pNJtTherEB66E1FQOGJCU7P5mkBeI4aFJ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJVwhwpAAoJEKeha0olJ0NqjEkH/A++m1/LMoCAaZJkYJKNdrQo
BhNunaB3xHQuIqx/HjEHYRBPKsQ7Zoj9h9s8r1YFAkfXv+h6GbbLfrWmdEREoOTP
fKrE6L9BKYJnr1Bv9nCb6ospBQwkTRbl8VOJIL992lSO4bzkKLEULot8Zydo/NEh
qYIHrDeUNh/QQh1ZcDwvjB0IVtA8u4CiQ7WwUw1WpvKEcphscQXOEVy6v0Z1B4t9
4hHXA6+g6gxrvrVr9CV+onltI6ZnLoopSpLeoZipcp1R3vpBPe1zJsVE15Lgod9G
TcimXBgvf7w97b+CMtk+qkvS2VNI24zRhXcDB7qcIiqAuShFNL8ICgJI1eqQi0I=
=P+An
-----END PGP SIGNATURE-----

--pNJtTherEB66E1FQOGJCU7P5mkBeI4aFJ--