From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40554) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZN0PV-0007xk-Gf for qemu-devel@nongnu.org; Wed, 05 Aug 2015 11:15:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZN0PR-0007b6-CP for qemu-devel@nongnu.org; Wed, 05 Aug 2015 11:15:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45980) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZN0PR-0007av-64 for qemu-devel@nongnu.org; Wed, 05 Aug 2015 11:15:13 -0400 References: <1438703896-12553-1-git-send-email-armbru@redhat.com> <1438703896-12553-11-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55C2287A.60401@redhat.com> Date: Wed, 5 Aug 2015 09:15:06 -0600 MIME-Version: 1.0 In-Reply-To: <1438703896-12553-11-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="s41L0pgUOpVRiNL2SWNssG7xLQeUapuR3" Subject: Re: [Qemu-devel] [PATCH RFC v3 10/32] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, berto@igalia.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --s41L0pgUOpVRiNL2SWNssG7xLQeUapuR3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/04/2015 09:57 AM, Markus Armbruster wrote: > Fixes flat unions to get the base's base members. Test case is from > commit 2fc0043, in qapi-schema-test.json: >=20 >=20 > Flat union visitors remain broken. They'll be fixed next. >=20 > Signed-off-by: Markus Armbruster > --- > docs/qapi-code-gen.txt | 51 +++--- Thanks for updating the docs. The diffstat of the actual generated code is large, but the extra commits prove that in the end it's the same material, just in different ordering. Meanwhile, the doc example is correct, and being much shorter, makes it easier to see the sort of reordering that happened. > scripts/qapi-types.py | 273 ++++++++++++++----------= -------- > tests/qapi-schema/qapi-schema-test.json | 4 +- > 3 files changed, 144 insertions(+), 184 deletions(-) >=20 > + > +# If you link code generated from multiple schemata, you want only one= > +# instance include the code generated for built-in types. Generate it= s/include/of/ > +# only when do_builtins, enabled by command line option -b. See also > +# QAPISchemaGenTypeVisitor.visit_end(). > do_builtins =3D False With the grammar fix, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --s41L0pgUOpVRiNL2SWNssG7xLQeUapuR3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVwih6AAoJEKeha0olJ0NqbxMH/07hJIOPKnVMVe9lJqaJ+M9L ky4mgNpjRXAuxSwqhpmbxJkLSpeIveISe0uHUIh0xkPZYOf0VffudMcWcSiuh/oH zuet3wBmsBJcDIZSzvs1v4qBqwN/1kvsIFBzAtBeTljkNOVVxaO3XY8gkkrMJU8+ cYbjXG1mCFjmb4Wmk9V7mmDLoOCes7BZU+l2asKJ9uKLe/MdDKMq9JHQg8H4fMgx xhd6ypvUvctAjfhxzXEpLcl5J6q71Aw9eXP88NRv6Lj8VCGYqMN8dp68kwI0klpR DfjPpaP11oyuufMRPQADiFF4J7F5DZ+V44C0arNDLl6HINy4DL1jpxmr1SQBz9g= =cBWC -----END PGP SIGNATURE----- --s41L0pgUOpVRiNL2SWNssG7xLQeUapuR3--