From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZN267-0002ae-Vl for qemu-devel@nongnu.org; Wed, 05 Aug 2015 13:03:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZN263-0000T5-9B for qemu-devel@nongnu.org; Wed, 05 Aug 2015 13:03:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZN263-0000SM-3n for qemu-devel@nongnu.org; Wed, 05 Aug 2015 13:03:19 -0400 References: <1438703896-12553-1-git-send-email-armbru@redhat.com> <1438703896-12553-19-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55C23640.8050405@redhat.com> Date: Wed, 5 Aug 2015 10:13:52 -0600 MIME-Version: 1.0 In-Reply-To: <1438703896-12553-19-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vv2WpxwpjbHWXfxD56itBI1FB9P02KdFK" Subject: Re: [Qemu-devel] [PATCH RFC v3 18/32] qapi: Replace dirty is_c_ptr() by method c_null() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, berto@igalia.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vv2WpxwpjbHWXfxD56itBI1FB9P02KdFK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/04/2015 09:58 AM, Markus Armbruster wrote: > is_c_ptr() looks whether the end of the C text for the type looks like > a pointer. Works, but is fragile. >=20 > We now have a better tool: use QAPISchemaType method c_null(). The > initializers for non-pointers become prettier: 0, false or the > enumeration constant with the value 0 instead of {0}. >=20 > One place looks suspicious: we initialize pointers, but not > non-pointers. Either the initialization is superfluous and should be > deleted, or the non-pointers need it as well, or something subtle is > going on and needs a comment. Since I lack the time to figure it out > now, mark it FIXME. Dead paragraph. >=20 > Signed-off-by: Markus Armbruster > --- > scripts/qapi-commands.py | 16 +++++----------- > scripts/qapi.py | 3 --- > 2 files changed, 5 insertions(+), 14 deletions(-) >=20 With fixed commit message, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --vv2WpxwpjbHWXfxD56itBI1FB9P02KdFK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVwjZBAAoJEKeha0olJ0Nqrh8H/RJqcImekaxjOvDuDUH8L6Ch N5WHbFs2dulRkv+wvTChTmK2uNreyVpEy3OsMSWjq3q4EcJyUjgi648dYoUblQFG bnQrvdtOgpqKmgcZAmrolBbaeU8EwJw3099kxipdKDPb7dThF07DPy/FBvgzXztT W4n4eDffBEci3NOlcuh2gmQ8G2rJ4iY1435cjdhKFZ86OMc+kDRZa5A5bk5lRFce JEU2vT399DSQudeQ0rd456VUrzqxHu7+YcJFXf0K6TlNrUtdZPESzkllwcljOCXc 4mj5LcTLv92X4hw1iFRh9ywLDtghgYovu7/oZVLmNb62fHLMgl8synxVgb9oGCg= =MqHK -----END PGP SIGNATURE----- --vv2WpxwpjbHWXfxD56itBI1FB9P02KdFK--