From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZN1ZV-0000Ih-SB for qemu-devel@nongnu.org; Wed, 05 Aug 2015 12:29:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZN1ZO-0002Yv-Tl for qemu-devel@nongnu.org; Wed, 05 Aug 2015 12:29:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39841) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZN1ZO-0002Ye-O3 for qemu-devel@nongnu.org; Wed, 05 Aug 2015 12:29:34 -0400 References: <1438703896-12553-1-git-send-email-armbru@redhat.com> <1438703896-12553-20-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55C239E8.4030709@redhat.com> Date: Wed, 5 Aug 2015 10:29:28 -0600 MIME-Version: 1.0 In-Reply-To: <1438703896-12553-20-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MBvBN3jJTol5eAKV8RRF9lILu50GRmIEQ" Subject: Re: [Qemu-devel] [PATCH RFC v3 19/32] qapi: Clean up after recent conversions to QAPISchemaVisitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, berto@igalia.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MBvBN3jJTol5eAKV8RRF9lILu50GRmIEQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/04/2015 09:58 AM, Markus Armbruster wrote: > Generate just 'FOO' instead of 'struct FOO' when possible. >=20 > Drop helper functions that are now unused. >=20 > Make pylint reasonably happy. >=20 > Rename generate_FOO() functions to gen_FOO() for consistency. >=20 > Use more consistent and sensible variable names. >=20 > Consistently use c_ for mapping keys when their value is a C > identifier or type. >=20 > Simplify gen_enum() and gen_visit_union() >=20 > Consistently use single quotes for C text string literals. >=20 > Signed-off-by: Markus Armbruster > --- > docs/qapi-code-gen.txt | 2 +- > scripts/qapi-commands.py | 129 +++++++++++++++++++++++----------------= ------- > scripts/qapi-event.py | 121 ++++++++++++++++++++-------------------= ---- > scripts/qapi-types.py | 64 +++++++++++------------ > scripts/qapi-visit.py | 119 +++++++++++++++++++++------------------= --- > scripts/qapi.py | 131 +++++++++------------------------------= -------- > 6 files changed, 239 insertions(+), 327 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --MBvBN3jJTol5eAKV8RRF9lILu50GRmIEQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVwjnpAAoJEKeha0olJ0NqiiYH/1v1QJ0QeU53l1/V1BeTLsse Rtz8sK0W7nwK1tWPR62ptKgubJdmP+FNnvGfcPPQ90Ef6TbAEr9MuySpDRcO24wk Bro51AbFjxxW5RYx6XRLP8iOkvmshES41JEls/s6/XoT3kGMnPmaGD2AI7sUdKCx oYa+Tn6598ucGbvWLgP89ysARkUEkucXQRdIdZkYAvGM3Dl/tmwNtAybNo6mZes5 XOmVhtTrydooALB4BnZBjJMNF9NwcYPdGPGleSv5JG0T1AOBznP6gwbiK7aceu0l LKUX4/LP1A6R6tg9tAQxd2SiyszrDfx9mxM28l4AtclcHpZjA1GFtKKoiKaUiNI= =VwKt -----END PGP SIGNATURE----- --MBvBN3jJTol5eAKV8RRF9lILu50GRmIEQ--