Re: [Qemu-devel] [PATCH v4 10/11] filter/buffer: update command description and help

[Jason Wang <jasowang@redhat.com>]

On 08/06/2015 03:31 PM, Yang Hongyang wrote:
>
>
> On 08/06/2015 03:22 PM, Jason Wang wrote:
>>
>>
>> On 08/04/2015 04:30 PM, Yang Hongyang wrote:
>>> now that we have a buffer netfilter, update the command
>>> description and help.
>>>
>>> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
>>> CC: Luiz Capitulino <lcapitulino@redhat.com>
>>> CC: Markus Armbruster <armbru@redhat.com>
>>> ---
>>>   hmp-commands.hx | 2 +-
>>>   qemu-options.hx | 5 ++++-
>>>   qmp-commands.hx | 2 +-
>>>   3 files changed, 6 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/hmp-commands.hx b/hmp-commands.hx
>>> index 902e2d1..63177a8 100644
>>> --- a/hmp-commands.hx
>>> +++ b/hmp-commands.hx
>>> @@ -1255,7 +1255,7 @@ ETEXI
>>>       {
>>>           .name       = "netfilter_add",
>>>           .args_type  = "netfilter:O",
>>> -        .params     =
>>> "[type],id=str,netdev=str[,chain=in|out|all,prop=value][,...]",
>>> +        .params     =
>>> "[buffer],id=str,netdev=str[,chain=in|out|all,prop=value][,...]",
>>
>> Looks like chain is mandatory in patch 2.
>
> It is optional, default is "all". 

Right, I see.