From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNHFy-0004yr-0t for qemu-devel@nongnu.org; Thu, 06 Aug 2015 05:14:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZNHFu-0000wz-Pd for qemu-devel@nongnu.org; Thu, 06 Aug 2015 05:14:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37589) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNHFu-0000wv-Ji for qemu-devel@nongnu.org; Thu, 06 Aug 2015 05:14:30 -0400 References: <1438818474-31373-1-git-send-email-somlo@cmu.edu> <1438818474-31373-3-git-send-email-somlo@cmu.edu> From: Laszlo Ersek Message-ID: <55C32571.5000103@redhat.com> Date: Thu, 6 Aug 2015 11:14:25 +0200 MIME-Version: 1.0 In-Reply-To: <1438818474-31373-3-git-send-email-somlo@cmu.edu> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/2] fw_cfg: document MMIO registers for arm, sun4*, and ppc/mac_* List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, gsomlo@gmail.com, kraxel@redhat.com On 08/06/15 01:47, Gabriel L. Somlo wrote: > Signed-off-by: Gabriel Somlo > --- > docs/specs/fw_cfg.txt | 22 +++++++++++++++++++--- > 1 file changed, 19 insertions(+), 3 deletions(-) > > diff --git a/docs/specs/fw_cfg.txt b/docs/specs/fw_cfg.txt > index 5bc7b96..f37e1ad 100644 > --- a/docs/specs/fw_cfg.txt > +++ b/docs/specs/fw_cfg.txt > @@ -72,10 +72,26 @@ increasing address order, similar to memcpy(). > > == Register Locations == > > -=== x86, x86_64 Register Locations === > +=== x86, x86_64, sun4u Register Locations === > + > +Selector Register IOport: 0x510 (16-bit, little-endian) > +Data Register IOport: 0x511 (8-bit) > + > +=== arm Register Locations === > + > +Selector Register MMIO addr: 0x9020008 (16-bit, big-endian) > +Data Register MMIO addr: 0x9020000 (64-bit) Suggestions: - maybe mention that this is specific to the "virt" machtype - mention that the exact location comes from the DTB, and hint at "Documentation/devicetree/bindings/arm/fw-cfg.txt" in the kernel tree - for the data register, rather than just "(64-bit)", consider saying "(64-bit, endianless, string-preserving)" > + > +=== sun4m Register Locations === > + > +Selector Register MMIO addr: 0xd00000510 (16-bit, big-endian) > +Data Register MMIO addr: 0xd00000512 (8-bit) > + > +=== ppc/mac Register Locations === > + > +Selector Register MMIO addr: 0xf0000510 (16-bit, big-endian) > +Data Register MMIO addr: 0xf0000512 (8-bit) Should these be tied to machine types? (I got no clue, I've never even built these targets.) Thanks Laszlo > > -Selector Register IOport: 0x510 > -Data Register IOport: 0x511 > > == Firmware Configuration Items == > >