From: Eric Blake <eblake@redhat.com>
To: Alberto Garcia <berto@igalia.com>, Max Reitz <mreitz@redhat.com>,
qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v9 08/10] qcow2: Invoke refcount order amendment function
Date: Thu, 6 Aug 2015 21:34:52 -0600 [thread overview]
Message-ID: <55C4275C.50403@redhat.com> (raw)
In-Reply-To: <w518u9obggl.fsf@maestria.local.igalia.com>
[-- Attachment #1: Type: text/plain, Size: 791 bytes --]
On 08/06/2015 09:10 AM, Alberto Garcia wrote:
> On Mon 27 Jul 2015 05:51:38 PM CEST, Max Reitz wrote:
>
>> + if (refcount_bits <= 0 || refcount_bits > 64 ||
>> + !is_power_of_2(refcount_bits))
>> + {
>> + error_report("Refcount width must be a power of two and may "
>> + "not exceed 64 bits");
>> + return -EINVAL;
>> + }
>
> I guess there's no lower limit needed for this? Doesn't it break
> anything if refcount_bits == 1?
refcount_bits == 1 works just fine - you have an image that can't take
internal snapshots, and has a maximally dense refblock.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-08-07 3:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 15:51 [Qemu-devel] [PATCH v9 00/10] qcow2: Support refcount order amendment Max Reitz
2015-07-27 15:51 ` [Qemu-devel] [PATCH v9 01/10] progress: Allow regressing progress Max Reitz
2015-07-27 15:51 ` [Qemu-devel] [PATCH v9 02/10] block: Add opaque value to the amend CB Max Reitz
2015-08-06 14:45 ` Alberto Garcia
2015-07-27 15:51 ` [Qemu-devel] [PATCH v9 03/10] qcow2: Use error_report() in qcow2_amend_options() Max Reitz
2015-07-27 15:51 ` [Qemu-devel] [PATCH v9 04/10] qcow2: Use abort() instead of assert(false) Max Reitz
2015-07-27 15:51 ` [Qemu-devel] [PATCH v9 05/10] qcow2: Split upgrade/downgrade paths for amend Max Reitz
2015-07-27 15:51 ` [Qemu-devel] [PATCH v9 06/10] qcow2: Use intermediate helper CB " Max Reitz
2015-07-27 15:51 ` [Qemu-devel] [PATCH v9 07/10] qcow2: Add function for refcount order amendment Max Reitz
2015-07-27 15:51 ` [Qemu-devel] [PATCH v9 08/10] qcow2: Invoke refcount order amendment function Max Reitz
2015-07-27 15:59 ` Eric Blake
2015-08-06 15:10 ` Alberto Garcia
2015-08-07 3:34 ` Eric Blake [this message]
2015-07-27 15:51 ` [Qemu-devel] [PATCH v9 09/10] qcow2: Point to amend function in check Max Reitz
2015-07-27 15:51 ` [Qemu-devel] [PATCH v9 10/10] iotests: Extend test 112 for qemu-img amend Max Reitz
2015-12-08 15:48 ` [Qemu-devel] [PATCH v9 00/10] qcow2: Support refcount order amendment Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C4275C.50403@redhat.com \
--to=eblake@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).