From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49204)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZOpM1-0007WH-3F
	for qemu-devel@nongnu.org; Mon, 10 Aug 2015 11:51:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZOpLy-0004Wy-8k
	for qemu-devel@nongnu.org; Mon, 10 Aug 2015 11:51:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53589)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZOpLy-0004Wn-2o
	for qemu-devel@nongnu.org; Mon, 10 Aug 2015 11:51:10 -0400
References: <1439220437-23957-1-git-send-email-fred.konrad@greensocs.com>
	<1439220437-23957-11-git-send-email-fred.konrad@greensocs.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55C8C867.9070409@redhat.com>
Date: Mon, 10 Aug 2015 17:51:03 +0200
MIME-Version: 1.0
In-Reply-To: <1439220437-23957-11-git-send-email-fred.konrad@greensocs.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH V7 10/19] cpu: remove exit_request
	global.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: fred.konrad@greensocs.com, qemu-devel@nongnu.org, mttcg@greensocs.com
Cc: mark.burton@greensocs.com, alex.bennee@linaro.org, a.rigo@virtualopensystems.com, guillaume.delbergue@greensocs.com



On 10/08/2015 17:27, fred.konrad@greensocs.com wrote:
>  {
>      if (current_cpu) {
>          cpu_exit(current_cpu);
>      }
> -    exit_request = 1;
> +
> +    /* FIXME: We might want to check if the cpu is running? */
> +    tcg_thread_cpu->exit_request = true;
>  }
>  
>  #ifdef CONFIG_LINUX
> @@ -1151,6 +1159,7 @@ static void *qemu_tcg_cpu_thread_fn(void *arg)
>      CPUState *cpu = arg;
>  
>      qemu_mutex_lock_iothread();
> +    tcg_thread_cpu = cpu;
>      qemu_tcg_init_cpu_signals();
>      qemu_thread_get_self(cpu->thread);

This only makes sense for MTTCG, so it should be squashed in patch 11, I
think.

Paolo