From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49239) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOpMJ-0007pg-Jj for qemu-devel@nongnu.org; Mon, 10 Aug 2015 11:51:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZOpMG-0004cZ-SC for qemu-devel@nongnu.org; Mon, 10 Aug 2015 11:51:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39384) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOpMG-0004cQ-MT for qemu-devel@nongnu.org; Mon, 10 Aug 2015 11:51:28 -0400 References: <1439220437-23957-1-git-send-email-fred.konrad@greensocs.com> <1439220437-23957-19-git-send-email-fred.konrad@greensocs.com> From: Paolo Bonzini Message-ID: <55C8C877.5020601@redhat.com> Date: Mon, 10 Aug 2015 17:51:19 +0200 MIME-Version: 1.0 In-Reply-To: <1439220437-23957-19-git-send-email-fred.konrad@greensocs.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH V7 18/19] mttcg: signal the associated cpu anyway. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: fred.konrad@greensocs.com, qemu-devel@nongnu.org, mttcg@greensocs.com Cc: mark.burton@greensocs.com, alex.bennee@linaro.org, a.rigo@virtualopensystems.com, guillaume.delbergue@greensocs.com On 10/08/2015 17:27, fred.konrad@greensocs.com wrote: > diff --git a/cpus.c b/cpus.c > index 2c5ca72..f61530c 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -674,8 +674,7 @@ static void cpu_signal(int sig) > cpu_exit(current_cpu); > } > > - /* FIXME: We might want to check if the cpu is running? */ > - tcg_thread_cpu->exit_request = true; > + cpu_exit(tcg_thread_cpu); If you do this, you can remove the first "if" too, because current_cpu is always either tcg_thread_cpu or NULL. I think it's okay to do that and squash this patch into patch 11 as well. Paolo