From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60042)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZOpu8-0001KE-CN
	for qemu-devel@nongnu.org; Mon, 10 Aug 2015 12:26:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZOpu3-0005Th-EL
	for qemu-devel@nongnu.org; Mon, 10 Aug 2015 12:26:28 -0400
Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:34653)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZOpu3-0005Sy-77
	for qemu-devel@nongnu.org; Mon, 10 Aug 2015 12:26:23 -0400
Received: by wicne3 with SMTP id ne3so142831012wic.1
	for <qemu-devel@nongnu.org>; Mon, 10 Aug 2015 09:26:21 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1439220437-23957-1-git-send-email-fred.konrad@greensocs.com>
	<1439220437-23957-17-git-send-email-fred.konrad@greensocs.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55C8D0A9.7010902@redhat.com>
Date: Mon, 10 Aug 2015 18:26:17 +0200
MIME-Version: 1.0
In-Reply-To: <1439220437-23957-17-git-send-email-fred.konrad@greensocs.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH V7 16/19] translate-all: introduces
	tb_flush_safe.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: fred.konrad@greensocs.com, qemu-devel@nongnu.org, mttcg@listserver.greensocs.com
Cc: alex.bennee@linaro.org, mark.burton@greensocs.com, a.rigo@virtualopensystems.com, guillaume.delbergue@greensocs.com



On 10/08/2015 17:27, fred.konrad@greensocs.com wrote:
> +
> +void tb_flush_safe(CPUState *cpu)
> +{
> +#if 0 /* !MTTCG */
> +    tb_flush(cpu);
> +#else
> +    async_run_safe_work_on_cpu(cpu, tb_flush_work, cpu);
> +#endif /* MTTCG */
> +}
> +

I think this can use first_cpu unconditionally; tb_flush only uses its
argument for an error message.

In fact, I think that by definition async_run_safe_work_on_cpu can use
any CPU for its work; it locks out everyone else, so it does not matter
which thread you're on.  So async_run_safe_work_on_cpu could drop the
@cpu argument (becoming async_run_safe_cpu_work) and use first_cpu
unconditionally.

Paolo