From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOq8u-0004mr-0a for qemu-devel@nongnu.org; Mon, 10 Aug 2015 12:41:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZOq8p-0005fk-Rn for qemu-devel@nongnu.org; Mon, 10 Aug 2015 12:41:43 -0400 Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:35981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOq8p-0005ed-L7 for qemu-devel@nongnu.org; Mon, 10 Aug 2015 12:41:39 -0400 Received: by wicja10 with SMTP id ja10so44248973wic.1 for ; Mon, 10 Aug 2015 09:41:39 -0700 (PDT) Sender: Paolo Bonzini References: <1439220437-23957-1-git-send-email-fred.konrad@greensocs.com> <1439220437-23957-20-git-send-email-fred.konrad@greensocs.com> From: Paolo Bonzini Message-ID: <55C8D440.900@redhat.com> Date: Mon, 10 Aug 2015 18:41:36 +0200 MIME-Version: 1.0 In-Reply-To: <1439220437-23957-20-git-send-email-fred.konrad@greensocs.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC PATCH V7 19/19] target-arm/psci.c: wake up sleeping CPUs (MTTCG) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: fred.konrad@greensocs.com, qemu-devel@nongnu.org, mttcg@listserver.greensocs.com Cc: alex.bennee@linaro.org, mark.burton@greensocs.com, a.rigo@virtualopensystems.com, guillaume.delbergue@greensocs.com On 10/08/2015 17:27, fred.konrad@greensocs.com wrote: > From: Alex Bennée > > Testing with Alexander's bare metal syncronisation tests fails in MTTCG > leaving one CPU spinning forever waiting for the second CPU to wake up. > We simply need to poke the halt_cond once we have processed the PSCI > power on call. > > Tested-by: Alex Bennée > CC: Alexander Spyridakis > --- > target-arm/psci.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/target-arm/psci.c b/target-arm/psci.c > index 20e4cb6..83e309c 100644 > --- a/target-arm/psci.c > +++ b/target-arm/psci.c > @@ -211,6 +211,8 @@ void arm_handle_psci_call(ARMCPU *cpu) > } > target_cpu_class->set_pc(target_cpu_state, entry); > > + qemu_cond_signal(target_cpu_state->halt_cond); > + qemu_cpu_kick, not qemu_cond_signal. Paolo > ret = 0; > break; > case QEMU_PSCI_0_1_FN_CPU_OFF: >