From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZP5U0-0000lr-HL for qemu-devel@nongnu.org; Tue, 11 Aug 2015 05:04:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZP5Tx-0002Za-8t for qemu-devel@nongnu.org; Tue, 11 Aug 2015 05:04:32 -0400 References: <1437566099-10004-1-git-send-email-lvivier@redhat.com> <1437726913-4534-1-git-send-email-lvivier@redhat.com> <55B5E99F.5090901@redhat.com> <55C9B764.3040807@suse.de> From: Laurent Vivier Message-ID: <55C9BA99.4000009@redhat.com> Date: Tue, 11 Aug 2015 11:04:25 +0200 MIME-Version: 1.0 In-Reply-To: <55C9B764.3040807@suse.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v3] pci: allow 0 address for PCI IO/MEM regions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org, David Gibson , qemu-ppc@nongnu.org, Michael Roth , "Michael S. Tsirkin" On 11/08/2015 10:50, Alexander Graf wrote: > > > On 27.07.15 10:19, Laurent Vivier wrote: >> Alex, >> >> could you ACK this patch ? >> >> It's not perfect and it will be removed later, but for the moment it >> allows to hotplug PCI card in pseries. > > PCIe definitely allows for BARs to be allocated to 0, so this is more or > less "the right thing". I really just wanted to make everyone aware that > I've run into issues with BARs actually located at address 0 in generic > PCI code in Linux ;). > > So I don't think you really need my ack, as you definitely don't have a > nack from my side. Thank you Alex ! Michael S. T, could you take the patch ? Thanks, Laurent