From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZP7BU-0005q3-Cn for qemu-devel@nongnu.org; Tue, 11 Aug 2015 06:53:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZP7BO-0003O6-Qm for qemu-devel@nongnu.org; Tue, 11 Aug 2015 06:53:32 -0400 Received: from mail-wi0-x22b.google.com ([2a00:1450:400c:c05::22b]:35815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZP7BO-0003Nz-IG for qemu-devel@nongnu.org; Tue, 11 Aug 2015 06:53:26 -0400 Received: by wicne3 with SMTP id ne3so55501757wic.0 for ; Tue, 11 Aug 2015 03:53:25 -0700 (PDT) Sender: Paolo Bonzini References: <1439220437-23957-1-git-send-email-fred.konrad@greensocs.com> <1439220437-23957-3-git-send-email-fred.konrad@greensocs.com> From: Paolo Bonzini Message-ID: <55C9D41E.3080405@redhat.com> Date: Tue, 11 Aug 2015 12:53:18 +0200 MIME-Version: 1.0 In-Reply-To: <1439220437-23957-3-git-send-email-fred.konrad@greensocs.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH V7 02/19] cpus: add tcg_exec_flag. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: fred.konrad@greensocs.com, qemu-devel@nongnu.org, mttcg@listserver.greensocs.com Cc: alex.bennee@linaro.org, mark.burton@greensocs.com, a.rigo@virtualopensystems.com, guillaume.delbergue@greensocs.com On 10/08/2015 17:27, fred.konrad@greensocs.com wrote: > @@ -583,5 +587,6 @@ int cpu_exec(CPUState *cpu) > > /* fail safe : never use current_cpu outside cpu_exec() */ > current_cpu = NULL; > + tcg_cpu_allow_execution(cpu); I don't think this is correct; safe_work_pending() is a much clearer test. I'll revert locally to the previous version to play more with the code. Paolo > return ret; > } > diff --git a/include/qom/cpu.h b/include/qom/cpu.h