From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48057)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZP9z3-0007sX-LQ
	for qemu-devel@nongnu.org; Tue, 11 Aug 2015 09:52:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZP9yz-0002HZ-4G
	for qemu-devel@nongnu.org; Tue, 11 Aug 2015 09:52:53 -0400
Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]:38476)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZP9yy-0002HN-Sm
	for qemu-devel@nongnu.org; Tue, 11 Aug 2015 09:52:49 -0400
Received: by wicja10 with SMTP id ja10so69674751wic.1
	for <qemu-devel@nongnu.org>; Tue, 11 Aug 2015 06:52:48 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1438966995-5913-1-git-send-email-a.rigo@virtualopensystems.com>
	<1438966995-5913-4-git-send-email-a.rigo@virtualopensystems.com>
	<CAH47eN3BNZQHnTat1uxVedzLq8+9YyWQjyS3kzMKe6ZctbARhw@mail.gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55C9FE28.9050403@redhat.com>
Date: Tue, 11 Aug 2015 15:52:40 +0200
MIME-Version: 1.0
In-Reply-To: <CAH47eN3BNZQHnTat1uxVedzLq8+9YyWQjyS3kzMKe6ZctbARhw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v4 3/9] softmmu: Add helpers for a new
	slowpath
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: alvise rigo <a.rigo@virtualopensystems.com>, QEMU Developers <qemu-devel@nongnu.org>, mttcg@listserver.greensocs.com
Cc: Claudio Fontana <claudio.fontana@huawei.com>, Jani Kokkonen <jani.kokkonen@huawei.com>, VirtualOpenSystems Technical Team <tech@virtualopensystems.com>, =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>



On 11/08/2015 15:32, alvise rigo wrote:
>> > +#if DATA_SIZE > 1
>> > +#define helper_ldlink_name  glue(glue(helper_le_ldlink, USUFFIX), MMUSUFFIX)
>> > +#define helper_stcond_name  glue(glue(helper_le_stcond, SUFFIX), MMUSUFFIX)
>> > +#define helper_ld_legacy glue(glue(helper_le_ld, USUFFIX), MMUSUFFIX)
>> > +#define helper_st_legacy glue(glue(helper_le_st, SUFFIX), MMUSUFFIX)
> Wouldn't be better here to not use the helpers from softmmu_template.h?
> Doing so, in softmmu_template.h we don't need to differentiate the
> normal stores from the SCs
> This at a cost of some additional boilerplate in softmmu_llsc_template.h.

A lot more boilerplate I think?

This patch looks good, I would just s/_legacy// because it's not really
legacy.

Paolo