From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPLLU-00076x-Ne for qemu-devel@nongnu.org; Tue, 11 Aug 2015 22:00:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPLLR-0001tx-HJ for qemu-devel@nongnu.org; Tue, 11 Aug 2015 22:00:48 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:35371) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPLLR-0001tb-CE for qemu-devel@nongnu.org; Tue, 11 Aug 2015 22:00:45 -0400 Received: by pacgr6 with SMTP id gr6so3048425pac.2 for ; Tue, 11 Aug 2015 19:00:43 -0700 (PDT) References: <1439190785-18908-1-git-send-email-gwshan@linux.vnet.ibm.com> <1439190785-18908-2-git-send-email-gwshan@linux.vnet.ibm.com> From: Alexey Kardashevskiy Message-ID: <55CAA8C3.8000802@ozlabs.ru> Date: Wed, 12 Aug 2015 12:00:35 +1000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 1/3] linux-headers: Add eeh.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Gavin Shan Cc: "qemu-ppc@nongnu.org" , QEMU Developers , David Gibson On 08/11/2015 07:11 PM, Peter Maydell wrote: > On 10 August 2015 at 08:13, Gavin Shan wrote: >> The header file was introduced by following Linux upstream commits: >> >> commit ed3e81f ("powerpc/eeh: Move PE state constants around") >> commit ec33d36 ("powerpc/eeh: Introduce eeh_pe_inject_err()") >> >> Signed-off-by: Gavin Shan >> --- >> linux-headers/asm-powerpc/eeh.h | 56 +++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 56 insertions(+) >> create mode 100644 linux-headers/asm-powerpc/eeh.h > > Shouldn't this be added by updating scripts/update-linux-headers.sh > and then doing a plain "synchronize headers against kernel version $X" ? I also thought this is the protocol but then I looked into the git history and discovered this is not always the case :) > Otherwise you won't get any future changes to this file. > > thanks > -- PMM > -- Alexey