From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37552)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPMwI-0006XH-DD
	for qemu-devel@nongnu.org; Tue, 11 Aug 2015 23:42:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPMwD-0004HZ-EQ
	for qemu-devel@nongnu.org; Tue, 11 Aug 2015 23:42:54 -0400
Received: from mail-qg0-x229.google.com ([2607:f8b0:400d:c04::229]:34996)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPMwD-0004HV-9n
	for qemu-devel@nongnu.org; Tue, 11 Aug 2015 23:42:49 -0400
Received: by qgj62 with SMTP id 62so3436501qgj.2
	for <qemu-devel@nongnu.org>; Tue, 11 Aug 2015 20:42:49 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1439151229-27747-1-git-send-email-laurent@vivier.eu>
	<1439151229-27747-3-git-send-email-laurent@vivier.eu>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <55CAC0B4.3010707@twiddle.net>
Date: Tue, 11 Aug 2015 20:42:44 -0700
MIME-Version: 1.0
In-Reply-To: <1439151229-27747-3-git-send-email-laurent@vivier.eu>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH for-2.5 02/30] m68k: manage scaled index
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, Andreas Schwab <schwab@linux-m68k.org>, gerg@uclinux.org

On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> Scaled index is not supported by 68000, 68008, and 68010.
>
>      EA = (bd + PC) + Xn.SIZE*SCALE + od
>
> Ignore it:
>
> M68000 FAMILY PROGRAMMER’S REFERENCE MANUAL
> 2.4 BRIEF EXTENSION WORD FORMAT COMPATIBILITY
>
> "If the MC68000 were to execute an instruction that
>   encoded a scaling factor, the scaling factor would be
>   ignored and would not access the desired memory address.
>   The earlier microprocessors do not recognize the brief
>   extension word formats implemented by newer processors.
>   Although they can detect illegal instructions, they do not
>   decode invalid encodings of the brief extension word formats
>   as exceptions."
>
> Signed-off-by: Laurent Vivier<laurent@vivier.eu>
> ---
>   target-m68k/translate.c | 5 +++++
>   1 file changed, 5 insertions(+)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~