From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57320)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPOQa-0001NS-Og
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 01:18:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPOQV-0000NP-Pg
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 01:18:16 -0400
Received: from mail-qg0-x22e.google.com ([2607:f8b0:400d:c04::22e]:36418)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPOQV-0000NL-KA
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 01:18:11 -0400
Received: by qgdd90 with SMTP id d90so4257191qgd.3
	for <qemu-devel@nongnu.org>; Tue, 11 Aug 2015 22:18:11 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1439151229-27747-1-git-send-email-laurent@vivier.eu>
	<1439151229-27747-10-git-send-email-laurent@vivier.eu>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <55CAD70E.4010709@twiddle.net>
Date: Tue, 11 Aug 2015 22:18:06 -0700
MIME-Version: 1.0
In-Reply-To: <1439151229-27747-10-git-send-email-laurent@vivier.eu>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.5 09/30] m68k: add X flag helpers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, Andreas Schwab <schwab@linux-m68k.org>, gerg@uclinux.org

On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> +#define SET_X_FLAG(opsize, a, b) do { \
> +    switch (opsize) { \
> +    case OS_BYTE: \
> +        gen_helper_xflag_lt_i8(QREG_CC_X, a, b); break; \
> +    case OS_WORD: \
> +        gen_helper_xflag_lt_i16(QREG_CC_X, a, b); break; \
> +    case OS_LONG: \
> +        gen_helper_xflag_lt_i32(QREG_CC_X, a, b); break; \
> +    default: \
> +        abort(); \
> +    } \
> +} while (0)

No need for these helpers.  Just use setcond now, with sign-extensions as 
required for the opsize.  And perhaps not make this a macro, but a function.

Also watch all of the tcg_const_i32 without freeing the temp after.


r~