From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58077)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPOTR-0003dC-Im
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 01:21:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPOTM-0001cD-Co
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 01:21:13 -0400
Received: from mail-qg0-x234.google.com ([2607:f8b0:400d:c04::234]:34320)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPOTM-0001bq-8T
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 01:21:08 -0400
Received: by qgeg42 with SMTP id g42so4340213qge.1
	for <qemu-devel@nongnu.org>; Tue, 11 Aug 2015 22:21:08 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1439151229-27747-1-git-send-email-laurent@vivier.eu>
	<1439151229-27747-12-git-send-email-laurent@vivier.eu>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <55CAD7B9.50600@twiddle.net>
Date: Tue, 11 Aug 2015 22:20:57 -0700
MIME-Version: 1.0
In-Reply-To: <1439151229-27747-12-git-send-email-laurent@vivier.eu>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.5 11/30] m68k: improve clr/moveq
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, Andreas Schwab <schwab@linux-m68k.org>, gerg@uclinux.org

On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> Generate the TCG constant and use it twice, instead
> of generating the TCG constant twice to use it twice.
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
>   target-m68k/translate.c | 15 +++++++++------
>   1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/target-m68k/translate.c b/target-m68k/translate.c
> index 359c761..8a3d315 100644
> --- a/target-m68k/translate.c
> +++ b/target-m68k/translate.c
> @@ -1431,10 +1431,13 @@ DISAS_INSN(lea)
>   DISAS_INSN(clr)
>   {
>       int opsize;
> +    TCGv zero;
> +
> +    zero = tcg_const_i32(0);

Ideally, on one line.  And it still needs to be freed.

>   DISAS_INSN(moveq)
>   {
> -    uint32_t val;
> +    TCGv val;
>
> +    val = tcg_const_i32((int8_t)insn);

Likewise.


r~