From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPPXk-00016c-L8 for qemu-devel@nongnu.org; Wed, 12 Aug 2015 02:29:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPPXe-0002mP-7F for qemu-devel@nongnu.org; Wed, 12 Aug 2015 02:29:44 -0400 Received: from mail-qk0-x22d.google.com ([2607:f8b0:400d:c09::22d]:34946) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPPXe-0002m2-36 for qemu-devel@nongnu.org; Wed, 12 Aug 2015 02:29:38 -0400 Received: by qkbm65 with SMTP id m65so2409892qkb.2 for ; Tue, 11 Aug 2015 23:29:37 -0700 (PDT) Sender: Richard Henderson References: <1439151229-27747-1-git-send-email-laurent@vivier.eu> <1439151229-27747-14-git-send-email-laurent@vivier.eu> From: Richard Henderson Message-ID: <55CAE7CC.7080901@twiddle.net> Date: Tue, 11 Aug 2015 23:29:32 -0700 MIME-Version: 1.0 In-Reply-To: <1439151229-27747-14-git-send-email-laurent@vivier.eu> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.5 13/30] m68k: set Z and N on divu/muls overflow as a real 68040 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, Andreas Schwab , gerg@uclinux.org On 08/09/2015 01:13 PM, Laurent Vivier wrote: > This allows to compare simulation results with a real 68040. > > Signed-off-by: Laurent Vivier > --- > target-m68k/op_helper.c | 38 ++++++++++++++++++++++++++------------ > 1 file changed, 26 insertions(+), 12 deletions(-) A good incentive, yes, but... hmm. Certainly another incentive to split helpers, rather than pass in "word". I don't have a way to review this though, so the best I can do is Acked-by: Richard Henderson r~