From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45688)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laurent@vivier.eu>) id 1ZPQz6-0007gZ-P1
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 04:02:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <laurent@vivier.eu>) id 1ZPQz0-0003ic-6K
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 04:02:04 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:56803)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laurent@vivier.eu>) id 1ZPQyz-0003hu-Rw
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 04:01:58 -0400
References: <1439151229-27747-1-git-send-email-laurent@vivier.eu>
	<1439151229-27747-2-git-send-email-laurent@vivier.eu>
	<55CA81B7.9080307@twiddle.net>
From: Laurent Vivier <laurent@vivier.eu>
Message-ID: <55CAFD62.6000701@vivier.eu>
Date: Wed, 12 Aug 2015 10:01:38 +0200
MIME-Version: 1.0
In-Reply-To: <55CA81B7.9080307@twiddle.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH for-2.5 01/30] m68k: define m680x0 CPUs and
 features
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, Andreas Schwab <schwab@linux-m68k.org>, gerg@uclinux.org



Le 12/08/2015 01:13, Richard Henderson a écrit :
> On 08/09/2015 01:13 PM, Laurent Vivier wrote:
>>      INSN(undef,     0000, 0000, CF_ISA_A);
>> +    INSN(undef,     0000, 0000, M68000);
>>      INSN(arith_im,  0080, fff8, CF_ISA_A);
>> +    INSN(arith_im,  0000, ff00, M68000);
>> +    INSN(undef,     00c0, ffc0, M68000);
>>      INSN(bitrev,    00c0, fff8, CF_ISA_APLUSC);
>>      INSN(bitop_reg, 0100, f1c0, CF_ISA_A);
>> +    INSN(bitop_reg, 0100, f1c0, M68000);
>>      INSN(bitop_reg, 0140, f1c0, CF_ISA_A);
>> +    INSN(bitop_reg, 0140, f1c0, M68000);
> 
> There's a *lot* of repetition in here.
> 
> Can we also introduce a BASE() macro that's like INSN() except that it doesn't
> bother checking m68k_feature?  That way if both CF_ISA_A and M68000 are set, we
> don't have to duplicate the entry.

Thank you, good idea.

Laurent