From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33237)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZPSlH-0007kj-86
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 05:55:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZPSlF-00047q-Vr
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 05:55:54 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1439413464-7326-1-git-send-email-liang.z.li@intel.com>
	<1439413464-7326-2-git-send-email-liang.z.li@intel.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55CB1820.6090603@redhat.com>
Date: Wed, 12 Aug 2015 11:55:44 +0200
MIME-Version: 1.0
In-Reply-To: <1439413464-7326-2-git-send-email-liang.z.li@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] migration: do cleanup operation after
	completion
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liang Li <liang.z.li@intel.com>, qemu-devel@nongnu.org
Cc: yang.z.zhang@intel.com, amit.shah@redhat.com, stefanha@redhat.com, qemu-block@nongnu.org, quintela@redhat.com



On 12/08/2015 23:04, Liang Li wrote:
> @@ -1008,8 +1009,10 @@ static void *migration_thread(void *opaque)
>      }
>  
>      qemu_mutex_lock_iothread();
> +    end_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME);
> +    qemu_savevm_state_cancel();
> +

You can remove the qemu_savevm_state_cancel() call from
migrate_fd_cleanup, too.  Probably best to post a v2 with that change as
well.

Paolo