From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPTvz-0007YF-SV for qemu-devel@nongnu.org; Wed, 12 Aug 2015 07:11:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPTvv-0008Fd-ST for qemu-devel@nongnu.org; Wed, 12 Aug 2015 07:11:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35152) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPTvv-0008FU-ND for qemu-devel@nongnu.org; Wed, 12 Aug 2015 07:10:59 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id E87C619D4A8 for ; Wed, 12 Aug 2015 11:10:58 +0000 (UTC) References: <1439374791-25879-1-git-send-email-marcel@redhat.com> <20150812133148-mutt-send-email-mst@redhat.com> From: Marcel Apfelbaum Message-ID: <55CB29C0.6060805@redhat.com> Date: Wed, 12 Aug 2015 14:10:56 +0300 MIME-Version: 1.0 In-Reply-To: <20150812133148-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio/vhost: drop unnecessary VHOST_SET_VRING call List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On 08/12/2015 01:34 PM, Michael S. Tsirkin wrote: > On Wed, Aug 12, 2015 at 01:19:51PM +0300, Marcel Apfelbaum wrote: >> No need to send VHOST_SET_VRING_CALL to backend >> before the negotiation with the guest is finished. >> >> Signed-off-by: Marcel Apfelbaum > > Well - we do need to set it to the masked notifier initially to avoid > losing events. You can't just drop it - need to move this call > somewhere else. What do we need to set? I just dropped the call to VHOST_SET_VRING_CALL. Thanks, Marcel > >> --- >> hw/virtio/vhost.c | 13 +------------ >> 1 file changed, 1 insertion(+), 12 deletions(-) >> >> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c >> index 2712c6f..b448542 100644 >> --- a/hw/virtio/vhost.c >> +++ b/hw/virtio/vhost.c >> @@ -875,24 +875,13 @@ static void vhost_eventfd_del(MemoryListener *listener, >> static int vhost_virtqueue_init(struct vhost_dev *dev, >> struct vhost_virtqueue *vq, int n) >> { >> - struct vhost_vring_file file = { >> - .index = n, >> - }; >> int r = event_notifier_init(&vq->masked_notifier, 0); >> + >> if (r < 0) { >> return r; >> } >> >> - file.fd = event_notifier_get_fd(&vq->masked_notifier); >> - r = dev->vhost_ops->vhost_call(dev, VHOST_SET_VRING_CALL, &file); >> - if (r) { >> - r = -errno; >> - goto fail_call; >> - } >> return 0; >> -fail_call: >> - event_notifier_cleanup(&vq->masked_notifier); >> - return r; >> } >> >> static void vhost_virtqueue_cleanup(struct vhost_virtqueue *vq) >> -- >> 2.1.0