From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56604)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZPWkD-0008BH-U9
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 10:11:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZPWkA-0004q4-KM
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 10:11:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35671)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZPWk9-0004pZ-Qy
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 10:11:02 -0400
References: <1438966995-5913-1-git-send-email-a.rigo@virtualopensystems.com>
	<1438966995-5913-2-git-send-email-a.rigo@virtualopensystems.com>
	<55C9FE29.2080204@redhat.com>
	<CAH47eN2Cq84G85gqVrUj1_re89sewC4crGj4WHb9CnpmbT+nWw@mail.gmail.com>
	<55CA1AF8.1090409@redhat.com>
	<CAH47eN2xF-=kJ27eTQuuwgvdSP2=dC12eUS1VxK70VpKopeNeg@mail.gmail.com>
	<55CA2383.60805@redhat.com>
	<CAH47eN34Frs9ySE6F5=GRQSHw+o-juXt18yeuS9C5i140wR3Pg@mail.gmail.com>
	<55CB3DEA.2050103@redhat.com>
	<CAH47eN2kapw-K1Za-O2ewhr_xaMWLM5rL3HMa=-fSUNPZ+5q7w@mail.gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55CB53EE.6030007@redhat.com>
Date: Wed, 12 Aug 2015 16:10:54 +0200
MIME-Version: 1.0
In-Reply-To: <CAH47eN2kapw-K1Za-O2ewhr_xaMWLM5rL3HMa=-fSUNPZ+5q7w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v4 1/9] exec.c: Add new exclusive bitmap to
	ram_list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: alvise rigo <a.rigo@virtualopensystems.com>
Cc: mttcg@greensocs.com, Claudio Fontana <claudio.fontana@huawei.com>, QEMU Developers <qemu-devel@nongnu.org>, Jani Kokkonen <jani.kokkonen@huawei.com>, VirtualOpenSystems Technical Team <tech@virtualopensystems.com>, =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>



On 12/08/2015 16:04, alvise rigo wrote:
>> > clear algorithm:
>> >    if bytemap[vaddr] == 254
>> >       bytemap[vaddr] = CPU_ID
> Isn't this also required for the clear algorithm?
> 
>     if bytemap[vaddr] < 254
>         /* this can happen for the TLB_EXCL slow path effect */
>         bytemap[vaddr] = 255

I don't think so because clear doesn't clear TLB_EXCL.  But maybe we're
talking about two different things. :)

Paolo