From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPWkX-00009u-HM for qemu-devel@nongnu.org; Wed, 12 Aug 2015 10:11:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPWkT-000514-Ja for qemu-devel@nongnu.org; Wed, 12 Aug 2015 10:11:25 -0400 Received: from greensocs.com ([193.104.36.180]:53569) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPWkT-00050u-9D for qemu-devel@nongnu.org; Wed, 12 Aug 2015 10:11:21 -0400 Message-ID: <55CB5405.5080309@greensocs.com> Date: Wed, 12 Aug 2015 16:11:17 +0200 From: Frederic Konrad MIME-Version: 1.0 References: <1439220437-23957-1-git-send-email-fred.konrad@greensocs.com> <1439220437-23957-17-git-send-email-fred.konrad@greensocs.com> <55CB537F.4060501@redhat.com> In-Reply-To: <55CB537F.4060501@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH V7 16/19] translate-all: introduces tb_flush_safe. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org, mttcg@listserver.greensocs.com Cc: alex.bennee@linaro.org, mark.burton@greensocs.com, a.rigo@virtualopensystems.com, guillaume.delbergue@greensocs.com On 12/08/2015 16:09, Paolo Bonzini wrote: > > On 10/08/2015 17:27, fred.konrad@greensocs.com wrote: >> From: KONRAD Frederic >> >> tb_flush is not thread safe we definitely need to exit VCPUs to do that. >> This introduces tb_flush_safe which just creates an async safe work which will >> do a tb_flush later. >> >> Signed-off-by: KONRAD Frederic > You could also allocate a new code buffer and free the old one with > call_rcu. This should simplify things a lot. > > Paolo Depending the size of the code buffer this might be a good idea. :). Fred