From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53255)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPXiL-0006iC-0a
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 11:13:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPXiF-0003qe-T5
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 11:13:12 -0400
Received: from mail-qk0-x233.google.com ([2607:f8b0:400d:c09::233]:34744)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPXiF-0003qY-O0
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 11:13:07 -0400
Received: by qkcs67 with SMTP id s67so6147738qkc.1
	for <qemu-devel@nongnu.org>; Wed, 12 Aug 2015 08:13:07 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1439151229-27747-1-git-send-email-laurent@vivier.eu>
	<1439151229-27747-16-git-send-email-laurent@vivier.eu>
	<55CAFB98.4030308@twiddle.net> <mvma8txj5g7.fsf@hawking.suse.de>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <55CB6280.5010403@twiddle.net>
Date: Wed, 12 Aug 2015 08:13:04 -0700
MIME-Version: 1.0
In-Reply-To: <mvma8txj5g7.fsf@hawking.suse.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.5 15/30] m68k: add more modes to movem
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, gerg@uclinux.org, Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org

On 08/12/2015 01:07 AM, Andreas Schwab wrote:
> Richard Henderson <rth@twiddle.net> writes:
> 
>> On 08/09/2015 01:13 PM, Laurent Vivier wrote:
>>> +    opsize = (insn & 0x40) != 0 ? OS_LONG : OS_WORD;
>>> +    incr = opsize_bytes(opsize);
>>> +    if (!is_load && (insn & 070) == 040) {
>>> +        for (i = 15; i >= 0; i--, mask >>= 1) {
>>
>> This has got to be wrong.  Just because it's pre-decrement doesn't mean
>> you should skip all of the loads.
> 
> Pre-dec only supports reg-to-mem, and is special because mask is bit
> reversed.

Ah, I'd never noticed that.  A comment to that effect would be good.


r~