From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPYsH-00046x-Fs for qemu-devel@nongnu.org; Wed, 12 Aug 2015 12:27:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPYsC-00006o-DB for qemu-devel@nongnu.org; Wed, 12 Aug 2015 12:27:33 -0400 Received: from mail-qg0-x22b.google.com ([2607:f8b0:400d:c04::22b]:33584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPYsC-00006d-9Z for qemu-devel@nongnu.org; Wed, 12 Aug 2015 12:27:28 -0400 Received: by qged69 with SMTP id d69so13914482qge.0 for ; Wed, 12 Aug 2015 09:27:28 -0700 (PDT) Sender: Richard Henderson References: <1439151229-27747-1-git-send-email-laurent@vivier.eu> <1439151229-27747-17-git-send-email-laurent@vivier.eu> From: Richard Henderson Message-ID: <55CB73ED.5020202@twiddle.net> Date: Wed, 12 Aug 2015 09:27:25 -0700 MIME-Version: 1.0 In-Reply-To: <1439151229-27747-17-git-send-email-laurent@vivier.eu> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.5 16/30] m68k: Add all access modes and data sizes to some 680x0 instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, Andreas Schwab , gerg@uclinux.org On 08/09/2015 01:13 PM, Laurent Vivier wrote: > - SRC_EA(env, tmp, OS_LONG, 0, &addr); > + SRC_EA(env, tmp, opsize, -1, &addr); Oh, I'm also wondering why you changed all of the inputs from unsigned to signed. It appears to be unrelated to updating the modes, and unnecessary. I'm all for reducing churn and doing both at once, so long as you say why. But at present it looks like a mistake. r~