From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38776)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPZn0-0003zv-PS
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 13:26:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPZmv-0004iG-DW
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 13:26:10 -0400
Received: from mail-qg0-x232.google.com ([2607:f8b0:400d:c04::232]:35970)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPZT3-0004pl-Kl
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 13:05:33 -0400
Received: by qgdd90 with SMTP id d90so14636973qgd.3
	for <qemu-devel@nongnu.org>; Wed, 12 Aug 2015 10:05:33 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1439151229-27747-1-git-send-email-laurent@vivier.eu>
	<1439151229-27747-21-git-send-email-laurent@vivier.eu>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <55CB7CDA.9090000@twiddle.net>
Date: Wed, 12 Aug 2015 10:05:30 -0700
MIME-Version: 1.0
In-Reply-To: <1439151229-27747-21-git-send-email-laurent@vivier.eu>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.5 20/30] m68k: add exg
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, Andreas Schwab <schwab@linux-m68k.org>, gerg@uclinux.org

On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
>  target-m68k/translate.c | 34 +++++++++++++++++++++++++++++++++-
>  1 file changed, 33 insertions(+), 1 deletion(-)
> 
> diff --git a/target-m68k/translate.c b/target-m68k/translate.c
> index adf4521..b7d15e9 100644
> --- a/target-m68k/translate.c
> +++ b/target-m68k/translate.c
> @@ -2035,10 +2035,42 @@ DISAS_INSN(and)
>      TCGv dest;
>      TCGv addr;
>      int opsize;
> +    int exg_mode;
>  
> +    dest = tcg_temp_new();
> +
> +    /* exg */
> +
> +    exg_mode = insn & 0x1f8;

Likewise, surely we can decode EXG separately from AND, and avoid doing so for
coldfire.


r~