From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPZbf-0005K2-Ax for qemu-devel@nongnu.org; Wed, 12 Aug 2015 13:14:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPZbb-00085T-2B for qemu-devel@nongnu.org; Wed, 12 Aug 2015 13:14:27 -0400 Received: from mail-qg0-x232.google.com ([2607:f8b0:400d:c04::232]:35120) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPZba-00085C-TG for qemu-devel@nongnu.org; Wed, 12 Aug 2015 13:14:22 -0400 Received: by qgj62 with SMTP id 62so14865235qgj.2 for ; Wed, 12 Aug 2015 10:14:22 -0700 (PDT) Sender: Richard Henderson References: <1439151229-27747-1-git-send-email-laurent@vivier.eu> <1439151229-27747-23-git-send-email-laurent@vivier.eu> From: Richard Henderson Message-ID: <55CB7EEA.1010902@twiddle.net> Date: Wed, 12 Aug 2015 10:14:18 -0700 MIME-Version: 1.0 In-Reply-To: <1439151229-27747-23-git-send-email-laurent@vivier.eu> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.5 22/30] m68k: add cas instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Andreas Schwab , gerg@uclinux.org On 08/09/2015 01:13 PM, Laurent Vivier wrote: > + gen_logic_cc(s, res, opsize); > + > + l1 = gen_new_label(); > + l2 = gen_new_label(); > + > + gen_jmpcc(s, 6 /* !Z */, l1); > + gen_store(s, opsize, addr, update); > + tcg_gen_br(l2); > + gen_set_label(l1); > + tcg_gen_mov_i32(cmp, dest); > + gen_set_label(l2); > + tcg_temp_free(dest); > + tcg_temp_free(addr); I would suggest writing this with movcond. It avoids the branch, which is requiring the use of the local temps. r~