From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38312)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPb3F-0005WB-Ti
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 14:47:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPb3B-0005vf-TC
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 14:47:01 -0400
Received: from mail-qk0-x236.google.com ([2607:f8b0:400d:c09::236]:35840)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPb3B-0005va-NW
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 14:46:57 -0400
Received: by qkdv3 with SMTP id v3so8238974qkd.3
	for <qemu-devel@nongnu.org>; Wed, 12 Aug 2015 11:46:57 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1439151229-27747-1-git-send-email-laurent@vivier.eu>
	<1439151229-27747-28-git-send-email-laurent@vivier.eu>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <55CB949E.20100@twiddle.net>
Date: Wed, 12 Aug 2015 11:46:54 -0700
MIME-Version: 1.0
In-Reply-To: <1439151229-27747-28-git-send-email-laurent@vivier.eu>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.5 27/30] m68k: add addx/subx/negx
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, Andreas Schwab <schwab@linux-m68k.org>, gerg@uclinux.org

On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> +    return (op1 & ~((1UL << bits) - 1)) | res;                          \

deposit32(op1, res, bits, 0)

Otherwise,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~