From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPdSe-0000wE-F2 for qemu-devel@nongnu.org; Wed, 12 Aug 2015 17:21:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPdSZ-0003JV-Ce for qemu-devel@nongnu.org; Wed, 12 Aug 2015 17:21:24 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:59462) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPdSZ-0003JR-2f for qemu-devel@nongnu.org; Wed, 12 Aug 2015 17:21:19 -0400 References: <1439151229-27747-1-git-send-email-laurent@vivier.eu> <1439151229-27747-9-git-send-email-laurent@vivier.eu> <55CAD5D2.5050200@twiddle.net> <55CBB31B.9030004@vivier.eu> <55CBB866.9000705@twiddle.net> From: Laurent Vivier Message-ID: <55CBB8C3.8030006@vivier.eu> Date: Wed, 12 Aug 2015 23:21:07 +0200 MIME-Version: 1.0 In-Reply-To: <55CBB866.9000705@twiddle.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH for-2.5 08/30] m68k: update CPU flags management List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Andreas Schwab , gerg@uclinux.org Le 12/08/2015 23:19, Richard Henderson a écrit : > On 08/12/2015 01:56 PM, Laurent Vivier wrote: >>>> -DEF_HELPER_2(flush_flags, void, env, i32) >>>> +DEF_HELPER_2(flush_flags, i32, env, i32) >>> >>> Modify to use DEF_HELPER_FLAGS while you're at it. At the moment it >>> reads some globals, but doesn't write any, or have any other side >>> effects. >> >> It writes "env->cc_x", so I guess I can't use DEF_HELPER_FLAGS ? > > Ah, missed that. So, no, not usefully. > >>> That const needs to be freed. >> >> perhaps I'm wrong, what I had understood is: >> >> tcg_const_i32() creates a tcg_temp_new_i32(), and tcg_temp_new_i32() are >> automatically freed at end of tcg block (whereas tcg_const_local adn >> tcg_temp_local are not). > > They are freed at the end of a basic block. But the total number of > temps affects the speed of the tcg code generator. So you can improve > the speed of qemu by freeing temporaries that are no longer needed. OK, thank you. I was wondering if it is useful to free temp or not... Laurent