From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46774)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPiBD-0008Ne-B8
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 22:23:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPiB7-0002xG-QT
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 22:23:43 -0400
Received: from mail-qg0-x230.google.com ([2607:f8b0:400d:c04::230]:35215)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPiB7-0002x1-NQ
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 22:23:37 -0400
Received: by qgj62 with SMTP id 62so23465720qgj.2
	for <qemu-devel@nongnu.org>; Wed, 12 Aug 2015 19:23:37 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1439151229-27747-1-git-send-email-laurent@vivier.eu>
	<1439151229-27747-28-git-send-email-laurent@vivier.eu>
	<55CB949E.20100@twiddle.net> <55CBE0C0.40307@vivier.eu>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <55CBFFA6.7030207@twiddle.net>
Date: Wed, 12 Aug 2015 19:23:34 -0700
MIME-Version: 1.0
In-Reply-To: <55CBE0C0.40307@vivier.eu>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH for-2.5 27/30] m68k: add addx/subx/negx
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, Andreas Schwab <schwab@linux-m68k.org>, gerg@uclinux.org

On 08/12/2015 05:11 PM, Laurent Vivier wrote:
>
>
> Le 12/08/2015 20:46, Richard Henderson a écrit :
>> On 08/09/2015 01:13 PM, Laurent Vivier wrote:
>>> +    return (op1 & ~((1UL << bits) - 1)) | res; \
>>
>> deposit32(op1, res, bits, 0)
>>
>
> You mean: deposit32(op1, 0, bits, res) ?

Yes, sorry.  The operand order is different for tcg_gen_deposit_i32.  ;-)


r~