From: tu bo <tubo@linux.vnet.ibm.com>
To: kwolf@redhat.com
Cc: qemu-devel@nongnu.org, armbru@redhat.com, mreitz@redhat.com,
mimu@linux.vnet.ibm.com, silbe@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v11 0/5] Update tests/qemu-iotests failing cases for the s390 platform
Date: Thu, 13 Aug 2015 19:06:07 +0800 [thread overview]
Message-ID: <55CC7A1F.9090602@linux.vnet.ibm.com> (raw)
In-Reply-To: <1435908530-25980-1-git-send-email-tubo@linux.vnet.ibm.com>
Max replied that ignoring the UTF-8 error for 130 patch reported by
checkpatch.pl is fine.
Could you please apply the series if there are no further objections.
thanks
On 07/03/2015 03:28 PM, Bo Tu wrote:
> v11.
> 1. Add Reviewed-by of Sascha
> 2. Refine code change in common.config in order to be easier to read and be shorter
> 3. Add more comments in patch description
> 4. Combine the fix for 041 and 055 in one patch since they address the same issue
> 5. Remove the fix for 051 since it fails now
> 6. checkpatch.pl reports invaid UTF-8 error for 130 patch, because 130.out contains
> some non-text data.
>
> v10.
> 1. Add Reviewed-by statements for test 049
> 2. Removed the backslash in qemu-option.c
> 3. Please apply the series if there are no further objections
>
> v9.
> 1.Fix issue of line over 80 characters for test 049
> 2.Add Reviewed-by statements for test 051,130
>
> v8.
> 1.Modify error message in qemu-option.c when image size is invalid
> 2.Remove Reviewed-by statements if any functional changes in a new patch version
> for test 049,051,130
> 3.Change patch subject for test 130
> 4.Add id definition for a drive which will work for all platforms in test 130
> 5.Disable virtio-scsi-pci for non-PCI systems in test 051
>
> v7.
> 1. Add a pc specific output file for test 130.
> 2. A new variable device_id is defined in test 130 to support multiplatform.
> 3. Update the output file for test 051 based on it's current output.
> 4. change util/qemu-option.c and test case 049, generate error message
> when image size is a negtive value or exceeds the maximum of uint64
>
> v6.
> 1. Change the filter name from _filter_s390 to _filter_orphan.
> 2. Update the output file for tese case 081 because no default floopy and cd-rom.
>
> v5:
> 1. Add a pc specific output file for test 051.
> 2. Add a filter to test case 051 to filter s390 specific warnings.
> 3. Check whether the machine type is pc or not rather than check whether the machine type
> is s390.
> 4. When using a machine specific reference file if the default machine has an alias then
> use the alias as the output file name otherwise use the default machine name as the output
> file name.
>
> v4:
> 1. Generate all patches based on the latest master branch.
> 2. Rearrange patches
>
> v3:
> 1. Fix a typo in v2.
>
> v2:
> 1. Drop the patches for test 039 for it has been fixed in upstream.
> 2. Integrate patches for test 071, 067 and 087.
> 3. Keep the other patches.
>
> v1:
> 1. updated the test suite to be default-machine-type-aware, from the previous platform-aware
> 2. created a new patch "qemu-iotests: run qemu with -nodefaults" to counterpart the impact from the commit:
> c88930a6866e74953e931ae749781e98e486e5c8
> qemu-char: Permit only a single "stdio" character device
>
> When more than one is used, the terminal settings aren't restored
> correctly on exit. Fixable. However, such usage makes no sense,
> because the users race for input, so outlaw it instead.
>
> If you want to connect multiple things to stdio, use the mux
> chardev.
> 3. updated all the checking of platform name to the current machine name
>
> Bo Tu (5):
> qemu-iotests: qemu machine type support
> qemu-iotests: disable default qemu devices for cross-platform
> compatibility
> qemu-iotests: s390x: fix test 041 and 055
> qemu-iotests: s390x: fix test 049, reject negative sizes in QemuOpts
> qemu-iotests: s390x: fix test 130
>
> tests/qemu-iotests/041 | 6 +
> tests/qemu-iotests/049.out | 10 +-
> tests/qemu-iotests/055 | 9 ++
> tests/qemu-iotests/067 | 8 +-
> tests/qemu-iotests/067.out | 266 +--------------------------------------
> tests/qemu-iotests/071.out | 4 -
> tests/qemu-iotests/081.out | 2 -
> tests/qemu-iotests/087.out | 12 --
> tests/qemu-iotests/130 | 8 +-
> tests/qemu-iotests/130.out | 4 +-
> tests/qemu-iotests/check | 5 +
> tests/qemu-iotests/common | 1 +
> tests/qemu-iotests/common.config | 11 +-
> tests/qemu-iotests/common.qemu | 2 +-
> tests/qemu-iotests/iotests.py | 1 +
> util/qemu-option.c | 5 +
> 16 files changed, 53 insertions(+), 301 deletions(-)
>
next prev parent reply other threads:[~2015-08-13 11:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 7:28 [Qemu-devel] [PATCH v11 0/5] Update tests/qemu-iotests failing cases for the s390 platform Bo Tu
2015-07-03 7:28 ` [Qemu-devel] [PATCH v11 1/5] qemu-iotests: qemu machine type support Bo Tu
2015-07-03 7:28 ` [Qemu-devel] [PATCH v11 2/5] qemu-iotests: disable default qemu devices for cross-platform compatibility Bo Tu
2015-07-03 7:28 ` [Qemu-devel] [PATCH v11 3/5] qemu-iotests: s390x: fix test 041 and 055 Bo Tu
2015-07-03 7:28 ` [Qemu-devel] [PATCH v11 4/5] qemu-iotests: s390x: fix test 049, reject negative sizes in QemuOpts Bo Tu
2015-07-03 7:28 ` [Qemu-devel] [PATCH v11 5/5] qemu-iotests: s390x: fix test 130 Bo Tu
2015-08-13 11:06 ` tu bo [this message]
2015-08-13 13:28 ` [Qemu-devel] [PATCH v11 0/5] Update tests/qemu-iotests failing cases for the s390 platform Kevin Wolf
2015-09-03 8:56 ` Sascha Silbe
2015-09-03 10:44 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CC7A1F.9090602@linux.vnet.ibm.com \
--to=tubo@linux.vnet.ibm.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mimu@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=silbe@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).