From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPqKz-0001Cv-JE for qemu-devel@nongnu.org; Thu, 13 Aug 2015 07:06:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPqKw-0001w0-PA for qemu-devel@nongnu.org; Thu, 13 Aug 2015 07:06:21 -0400 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:46983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPqKw-0001vg-5d for qemu-devel@nongnu.org; Thu, 13 Aug 2015 07:06:18 -0400 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 13 Aug 2015 16:36:13 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 447B23940064 for ; Thu, 13 Aug 2015 16:36:11 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay03.in.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t7DB6Ath4129098 for ; Thu, 13 Aug 2015 16:36:10 +0530 Received: from d28av02.in.ibm.com (localhost [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t7DB69Un030356 for ; Thu, 13 Aug 2015 16:36:09 +0530 Message-ID: <55CC7A1F.9090602@linux.vnet.ibm.com> Date: Thu, 13 Aug 2015 19:06:07 +0800 From: tu bo MIME-Version: 1.0 References: <1435908530-25980-1-git-send-email-tubo@linux.vnet.ibm.com> In-Reply-To: <1435908530-25980-1-git-send-email-tubo@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v11 0/5] Update tests/qemu-iotests failing cases for the s390 platform List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kwolf@redhat.com Cc: qemu-devel@nongnu.org, armbru@redhat.com, mreitz@redhat.com, mimu@linux.vnet.ibm.com, silbe@linux.vnet.ibm.com Max replied that ignoring the UTF-8 error for 130 patch reported by checkpatch.pl is fine. Could you please apply the series if there are no further objections. thanks On 07/03/2015 03:28 PM, Bo Tu wrote: > v11. > 1. Add Reviewed-by of Sascha > 2. Refine code change in common.config in order to be easier to read and be shorter > 3. Add more comments in patch description > 4. Combine the fix for 041 and 055 in one patch since they address the same issue > 5. Remove the fix for 051 since it fails now > 6. checkpatch.pl reports invaid UTF-8 error for 130 patch, because 130.out contains > some non-text data. > > v10. > 1. Add Reviewed-by statements for test 049 > 2. Removed the backslash in qemu-option.c > 3. Please apply the series if there are no further objections > > v9. > 1.Fix issue of line over 80 characters for test 049 > 2.Add Reviewed-by statements for test 051,130 > > v8. > 1.Modify error message in qemu-option.c when image size is invalid > 2.Remove Reviewed-by statements if any functional changes in a new patch version > for test 049,051,130 > 3.Change patch subject for test 130 > 4.Add id definition for a drive which will work for all platforms in test 130 > 5.Disable virtio-scsi-pci for non-PCI systems in test 051 > > v7. > 1. Add a pc specific output file for test 130. > 2. A new variable device_id is defined in test 130 to support multiplatform. > 3. Update the output file for test 051 based on it's current output. > 4. change util/qemu-option.c and test case 049, generate error message > when image size is a negtive value or exceeds the maximum of uint64 > > v6. > 1. Change the filter name from _filter_s390 to _filter_orphan. > 2. Update the output file for tese case 081 because no default floopy and cd-rom. > > v5: > 1. Add a pc specific output file for test 051. > 2. Add a filter to test case 051 to filter s390 specific warnings. > 3. Check whether the machine type is pc or not rather than check whether the machine type > is s390. > 4. When using a machine specific reference file if the default machine has an alias then > use the alias as the output file name otherwise use the default machine name as the output > file name. > > v4: > 1. Generate all patches based on the latest master branch. > 2. Rearrange patches > > v3: > 1. Fix a typo in v2. > > v2: > 1. Drop the patches for test 039 for it has been fixed in upstream. > 2. Integrate patches for test 071, 067 and 087. > 3. Keep the other patches. > > v1: > 1. updated the test suite to be default-machine-type-aware, from the previous platform-aware > 2. created a new patch "qemu-iotests: run qemu with -nodefaults" to counterpart the impact from the commit: > c88930a6866e74953e931ae749781e98e486e5c8 > qemu-char: Permit only a single "stdio" character device > > When more than one is used, the terminal settings aren't restored > correctly on exit. Fixable. However, such usage makes no sense, > because the users race for input, so outlaw it instead. > > If you want to connect multiple things to stdio, use the mux > chardev. > 3. updated all the checking of platform name to the current machine name > > Bo Tu (5): > qemu-iotests: qemu machine type support > qemu-iotests: disable default qemu devices for cross-platform > compatibility > qemu-iotests: s390x: fix test 041 and 055 > qemu-iotests: s390x: fix test 049, reject negative sizes in QemuOpts > qemu-iotests: s390x: fix test 130 > > tests/qemu-iotests/041 | 6 + > tests/qemu-iotests/049.out | 10 +- > tests/qemu-iotests/055 | 9 ++ > tests/qemu-iotests/067 | 8 +- > tests/qemu-iotests/067.out | 266 +-------------------------------------- > tests/qemu-iotests/071.out | 4 - > tests/qemu-iotests/081.out | 2 - > tests/qemu-iotests/087.out | 12 -- > tests/qemu-iotests/130 | 8 +- > tests/qemu-iotests/130.out | 4 +- > tests/qemu-iotests/check | 5 + > tests/qemu-iotests/common | 1 + > tests/qemu-iotests/common.config | 11 +- > tests/qemu-iotests/common.qemu | 2 +- > tests/qemu-iotests/iotests.py | 1 + > util/qemu-option.c | 5 + > 16 files changed, 53 insertions(+), 301 deletions(-) >