From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPsFn-0000RK-6r for qemu-devel@nongnu.org; Thu, 13 Aug 2015 09:09:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPsFi-0007Jf-8R for qemu-devel@nongnu.org; Thu, 13 Aug 2015 09:09:07 -0400 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:35104) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPsFh-0007Jb-Ve for qemu-devel@nongnu.org; Thu, 13 Aug 2015 09:09:02 -0400 Received: by wicne3 with SMTP id ne3so138969230wic.0 for ; Thu, 13 Aug 2015 06:09:01 -0700 (PDT) Sender: Paolo Bonzini References: <1439397664-70734-1-git-send-email-pbonzini@redhat.com> <1439397664-70734-3-git-send-email-pbonzini@redhat.com> <55CC962A.5020103@greensocs.com> From: Paolo Bonzini Message-ID: <55CC96E5.3060104@redhat.com> Date: Thu, 13 Aug 2015 15:08:53 +0200 MIME-Version: 1.0 In-Reply-To: <55CC962A.5020103@greensocs.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/10] cpus: remove tcg_halt_cond global variable. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Frederic Konrad , qemu-devel@nongnu.org Cc: mttcg@greensocs.com On 13/08/2015 15:05, Frederic Konrad wrote: >> >> >> This removes tcg_halt_cond global variable. >> We need one QemuCond per virtual cpu for multithread TCG. >> >> Signed-off-by: KONRAD Frederic >> Message-Id: <1439220437-23957-9-git-send-email-fred.konrad@greensocs.com> >> [Keep tcg_halt_cond for bisectability, while making it static. - Paolo] > How does that help bisectability? With your patch (08/19), QEMU will only wait on first_cpu->halt_cond but will call broadcast on cpu->halt_cond. Here I do the opposite: I wait on cpu->halt_cond from some random CPU, but all of them point to the same condvar tcg_halt_cond. Paolo