From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPsQE-0007MF-NQ for qemu-devel@nongnu.org; Thu, 13 Aug 2015 09:19:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPsQA-0003Gr-Mj for qemu-devel@nongnu.org; Thu, 13 Aug 2015 09:19:54 -0400 Received: from greensocs.com ([193.104.36.180]:42120) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPsQA-0003GM-GF for qemu-devel@nongnu.org; Thu, 13 Aug 2015 09:19:50 -0400 Message-ID: <55CC9972.8070704@greensocs.com> Date: Thu, 13 Aug 2015 15:19:46 +0200 From: Frederic Konrad MIME-Version: 1.0 References: <1439397664-70734-1-git-send-email-pbonzini@redhat.com> <1439397664-70734-3-git-send-email-pbonzini@redhat.com> <55CC962A.5020103@greensocs.com> <55CC96E5.3060104@redhat.com> In-Reply-To: <55CC96E5.3060104@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/10] cpus: remove tcg_halt_cond global variable. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: mttcg@greensocs.com On 13/08/2015 15:08, Paolo Bonzini wrote: > > On 13/08/2015 15:05, Frederic Konrad wrote: >>> >>> This removes tcg_halt_cond global variable. >>> We need one QemuCond per virtual cpu for multithread TCG. >>> >>> Signed-off-by: KONRAD Frederic >>> Message-Id: <1439220437-23957-9-git-send-email-fred.konrad@greensocs.com> >>> [Keep tcg_halt_cond for bisectability, while making it static. - Paolo] >> How does that help bisectability? > With your patch (08/19), QEMU will only wait on first_cpu->halt_cond but > will call broadcast on cpu->halt_cond. Here I do the opposite: I wait > on cpu->halt_cond from some random CPU, but all of them point to the > same condvar tcg_halt_cond. > > Paolo Ok got it. Fred