From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPtxr-00088p-Q8 for qemu-devel@nongnu.org; Thu, 13 Aug 2015 10:58:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPtxo-0005ql-HF for qemu-devel@nongnu.org; Thu, 13 Aug 2015 10:58:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53203) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPtxo-0005qT-Bi for qemu-devel@nongnu.org; Thu, 13 Aug 2015 10:58:40 -0400 References: <1439220437-23957-1-git-send-email-fred.konrad@greensocs.com> <1439220437-23957-12-git-send-email-fred.konrad@greensocs.com> <55CC7CBA.6030403@redhat.com> <55CCAC99.8030409@greensocs.com> From: Paolo Bonzini Message-ID: <55CCB099.2080406@redhat.com> Date: Thu, 13 Aug 2015 16:58:33 +0200 MIME-Version: 1.0 In-Reply-To: <55CCAC99.8030409@greensocs.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH V7 11/19] tcg: switch on multithread. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Frederic Konrad , qemu-devel@nongnu.org, mttcg@greensocs.com Cc: mark.burton@greensocs.com, alex.bennee@linaro.org, a.rigo@virtualopensystems.com, guillaume.delbergue@greensocs.com On 13/08/2015 16:41, Frederic Konrad wrote: >>> >> One issue here is that when tcg_cpu_exec returns EXCP_HALTED, the >> function keeps looping. There is no need to set cpu->exit_request in >> that case, since in fact there is no request pending, so the while loop >> probably should be an "if". > Nice catch thanks! > > I missed the fact that it was running through the list of VCPUs and > exited the > for(;;) loop. > > I should rework this patch a little.. Maybe it's better to keep this > loop and exit it > when necessary eg: when icount elapse or cpu halted. Yeah, I don't have a particularly strong opinion on that. You can look at my mttcg github branch for my rebase on top of yesterday's series. It seems to work at least on the small GreenSoCs buildroot image. Paolo