From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPuH2-0007Wf-Gp for qemu-devel@nongnu.org; Thu, 13 Aug 2015 11:18:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPuGx-0000d2-E6 for qemu-devel@nongnu.org; Thu, 13 Aug 2015 11:18:32 -0400 Received: from greensocs.com ([193.104.36.180]:39523) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPuGx-0000cx-4q for qemu-devel@nongnu.org; Thu, 13 Aug 2015 11:18:27 -0400 Message-ID: <55CCB53F.3000902@greensocs.com> Date: Thu, 13 Aug 2015 17:18:23 +0200 From: Frederic Konrad MIME-Version: 1.0 References: <1439220437-23957-1-git-send-email-fred.konrad@greensocs.com> <1439220437-23957-12-git-send-email-fred.konrad@greensocs.com> <55CC7CBA.6030403@redhat.com> <55CCAC99.8030409@greensocs.com> <55CCB099.2080406@redhat.com> In-Reply-To: <55CCB099.2080406@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH V7 11/19] tcg: switch on multithread. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org, mttcg@greensocs.com Cc: mark.burton@greensocs.com, alex.bennee@linaro.org, a.rigo@virtualopensystems.com, guillaume.delbergue@greensocs.com On 13/08/2015 16:58, Paolo Bonzini wrote: > > On 13/08/2015 16:41, Frederic Konrad wrote: >>> One issue here is that when tcg_cpu_exec returns EXCP_HALTED, the >>> function keeps looping. There is no need to set cpu->exit_request in >>> that case, since in fact there is no request pending, so the while loop >>> probably should be an "if". >> Nice catch thanks! >> >> I missed the fact that it was running through the list of VCPUs and >> exited the >> for(;;) loop. >> >> I should rework this patch a little.. Maybe it's better to keep this >> loop and exit it >> when necessary eg: when icount elapse or cpu halted. > Yeah, I don't have a particularly strong opinion on that. You can look > at my mttcg github branch for my rebase on top of yesterday's series. > It seems to work at least on the small GreenSoCs buildroot image. > > Paolo Their still seems to be something wrong with memory_region_rom_device_set_romd or something more general. I'm trying to find this. Fred