From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPvFK-0000xe-Cj for qemu-devel@nongnu.org; Thu, 13 Aug 2015 12:20:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPvFE-0005pw-Sz for qemu-devel@nongnu.org; Thu, 13 Aug 2015 12:20:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPvFE-0005pd-4e for qemu-devel@nongnu.org; Thu, 13 Aug 2015 12:20:44 -0400 References: <1439397664-70734-1-git-send-email-pbonzini@redhat.com> <1439397664-70734-12-git-send-email-pbonzini@redhat.com> <55CC92CC.4020201@greensocs.com> <55CC9496.8050905@redhat.com> <55CC9C6A.4070309@greensocs.com> <55CCAC0C.5090200@redhat.com> From: Paolo Bonzini Message-ID: <55CCC3D5.9020706@redhat.com> Date: Thu, 13 Aug 2015 18:20:37 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 11/10] tcg: comment on which functions have to be called with tb_lock held List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: mttcg@greensocs.com, QEMU Developers , Frederic Konrad On 13/08/2015 17:32, Peter Maydell wrote: >> > TBs are physically-tagged so invalidates are not too frequent unless the >> > guest does self-modifying code or swaps. They shouldn't be a source of >> > tb_lock contention except if you do SMC (not just dynamic recompilation: >> > really self-modifying code). > Do guests with writeable data and code in the same page also > get treated as SMC for these purposes? (That's more common > than real SMC.) Not after a short while, when the code_bitmap kicks in. Paolo