From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPwaP-00005E-DF for qemu-devel@nongnu.org; Thu, 13 Aug 2015 13:46:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPwaM-0004uN-6c for qemu-devel@nongnu.org; Thu, 13 Aug 2015 13:46:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPwaM-0004uJ-1j for qemu-devel@nongnu.org; Thu, 13 Aug 2015 13:46:38 -0400 References: <1439485767-20259-1-git-send-email-wei@redhat.com> <1439485767-20259-2-git-send-email-wei@redhat.com> From: Laszlo Ersek Message-ID: <55CCD7F4.80102@redhat.com> Date: Thu, 13 Aug 2015 19:46:28 +0200 MIME-Version: 1.0 In-Reply-To: <1439485767-20259-2-git-send-email-wei@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [ARM SMBIOS V4 PATCH 1/2] smbios: add smbios 3.0 support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Huang , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, drjones@redhat.com, ard.biesheuvel@linaro.org, ehabkost@redhat.com, ivan.khoronzhuk@linaro.org, mst@redhat.com, somlo@cmu.edu, zhaoshenglong@huawei.com, leif.lindholm@linaro.org, roy.franz@linaro.org, pbonzini@redhat.com, imammedo@redhat.com, jdelvare@suse.de, rth@twiddle.net On 08/13/15 19:09, Wei Huang wrote: > This patch adds support for SMBIOS 3.0 entry point. When caller invokes > smbios_set_defaults(), it can specify entry point as 2.1 or 3.0. Then > smbios_get_tables() will return the entry point table in right format. > > Acked-by: Gabriel Somlo > Tested-by: Gabriel Somlo > Tested-by: Leif Lindholm > Signed-off-by: Wei Huang > --- > hw/i386/pc_piix.c | 3 +- > hw/i386/pc_q35.c | 3 +- > hw/smbios/smbios.c | 84 +++++++++++++++++++++++++++++++++------------- > include/hw/smbios/smbios.h | 51 ++++++++++++++++++++-------- > 4 files changed, 102 insertions(+), 39 deletions(-) Diffed it against the corresponding v3 patch; I'm OK with this version too. Reviewed-by: Laszlo Ersek