From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPxE4-0003sn-U3 for qemu-devel@nongnu.org; Thu, 13 Aug 2015 14:27:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPxE0-000114-SL for qemu-devel@nongnu.org; Thu, 13 Aug 2015 14:27:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37438) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPxE0-0000yq-Kq for qemu-devel@nongnu.org; Thu, 13 Aug 2015 14:27:36 -0400 References: <1438360263-25445-1-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <55CCE191.4010206@redhat.com> Date: Thu, 13 Aug 2015 12:27:29 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NNummvUFA1pP7SpEDFFoNo9T6JFelt0uU" Subject: Re: [Qemu-devel] [PATCH RFC 00/10] Enable repository wide style checking List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , "Daniel P. Berrange" Cc: Bug-gnulib , QEMU Developers This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NNummvUFA1pP7SpEDFFoNo9T6JFelt0uU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [adding the gnulib list] On 08/13/2015 11:53 AM, Peter Maydell wrote: > On 31 July 2015 at 17:30, Daniel P. Berrange wrot= e: >> Historically QEMU has relied on the checkpatch.pl script, >> borrowed from Linux, to check coding style compliance on >> patches which are submitted. For what it is designed for, >> it does a reasonable job, but I feel that QEMU would benefit >> from some more checking in this area, in particular checks >> that run across the entire repository, not just new patches. >> >> Rather than attempt to replace checkpatch.pl, this series >> illustrates how we can augment our existing style compliance >> checking. This imports the infrastructure from GNULIB which >> provides a 'syntax-check' target in the makefiles. >=20 > I like this in principle, but I notice that the GNULIB > infrastructure is GPLv3. I really would strongly prefer > that we not introduce any GPLv3 code into QEMU's git tree. > I don't want to get into trying to figure out whether > part of our makefile or build infrastructure being GPLv3 > implies the generated binaries are GPLv3 or not; the simplest > approach is just to not allow any GPLv3 code into the git repo. >=20 > Is there no GPLv2 or GPLv2-or-later version of this code? Looks like gnulib.git commit fb7fde6f6 was the one that upgraded maint.mk to GPLv3+, on the grounds that building with GPLv3+ code does not infect your binary (see also the arguments in Autoconf, Automake, gcc... - but those tend to include an explicit exception clause to make it clear). Then again, qemu also avoids use of Autoconf and Automake. It's worth asking the gnulib folks for an opinion on whether relaxing the license on maint.mk and GNUmakefile to explicitly go back to GPLv2+, and/or explicitly add some explicit exception clause like gcc that makes it clear that using these files to build does not taint the built product. Personally, I see no problem with using GPLv3'd tools (after all, qemu requires GPLv3 GNU make, and gcc is also GPLv3 although clang can step around that one), but I also see your reluctance of even having a file in the qemu.git repo that has a GPLv3 clause. As one of the contributors to gnulib, I'm okay with my contributions to the files being relaxed; but we either need FSF blessing or consent from all contributors to the files in question, which could get a bit daunting= : $ git shortlog top/maint.mk build-aux/useless-if-before-free \ build-aux/vc-list-files | grep '^[^[:space:]]' Akim Demaille (16): Alfred M. Szmidt (2): Assaf Gordon (1): Daniel P. Berrange (1): Eric Blake (54): Gary V. Vaughan (4): Giuseppe Scrivano (1): Jim Meyering (174): Jiri Denemark (1): Joel E. Denny (2): Jose E. Marchesi (5): Karl Heuer (1): Martin von Gagern (1): Paul Eggert (4): Peter Rosin (1): Peter Simons (2): P=C3=A1draig Brady (6): Ralf Wildenhues (4): Reuben Thomas (2): Simon Josefsson (16): Soren Hansen (1): Stefano Lattarini (2): Theophile Ranquet (1): --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --NNummvUFA1pP7SpEDFFoNo9T6JFelt0uU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVzOGRAAoJEKeha0olJ0Nqfn0H/1F0Gmfqfa8Rj5Dx+7ul9/HU rL+EgDuj86nWOpVAfbsX5eBBymJRheZYnKdE9tJplu9QHT0fuEADN4R0Sr7p7Eqo mWS2kAlnTofOIZjTTd2VxCkx3z/yK94ETd3E3AajLykBrFymAVGtGueXAp2rDn1N ulMGrHyaidkCRuWW2KZbkbqUPWyczFYxo/SJyQXqkT/XQkofCMiZvuYE2oi76RZf 2i5tcOjdgeDGUlbd+vnPi605D0Xf+XQx4l0M65XX+GfPRJjq8BRxpVPFo76k09/e rfTyPywcP5W3+lLG5gd5OV5nSqaltzTTd2s5c0/e5F/kC8c47VARyRiY+93nJY8= =FpCb -----END PGP SIGNATURE----- --NNummvUFA1pP7SpEDFFoNo9T6JFelt0uU--