Re: [Qemu-devel] [PATCH v2 4/6] exec.c: Use pow2floor() rather than hand-calculation

[Paolo Bonzini <pbonzini@redhat.com>]

On 24/07/2015 14:33, Peter Maydell wrote:
> Use pow2floor() to round down to the nearest power of 2,
> rather than an inline calculation.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  exec.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/exec.c b/exec.c
> index 7d60e15..4710e2d 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -2371,9 +2371,7 @@ static int memory_access_size(MemoryRegion *mr, unsigned l, hwaddr addr)
>      if (l > access_size_max) {
>          l = access_size_max;
>      }
> -    if (l & (l - 1)) {
> -        l = 1 << (qemu_fls(l) - 1);
> -    }
> +    l = pow2floor(l);

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

>      return l;
>  }
>