From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQObk-0005UM-CZ for qemu-devel@nongnu.org; Fri, 14 Aug 2015 19:41:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZQObj-0006SD-Bv for qemu-devel@nongnu.org; Fri, 14 Aug 2015 19:41:56 -0400 Sender: Paolo Bonzini References: <1437741192-20955-1-git-send-email-peter.maydell@linaro.org> <1437741192-20955-6-git-send-email-peter.maydell@linaro.org> From: Paolo Bonzini Message-ID: <55CE7CBB.3070505@redhat.com> Date: Sat, 15 Aug 2015 01:41:47 +0200 MIME-Version: 1.0 In-Reply-To: <1437741192-20955-6-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 5/6] Remove unused qemu_fls function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Kevin Wolf , Keith Busch , patches@linaro.org, qemu-block@nongnu.org, "Michael S. Tsirkin" On 24/07/2015 14:33, Peter Maydell wrote: > Nothing uses qemu_fls() any more, so delete it. > > Signed-off-by: Peter Maydell > --- > include/qemu-common.h | 1 - > util/cutils.c | 5 ----- > 2 files changed, 6 deletions(-) > > diff --git a/include/qemu-common.h b/include/qemu-common.h > index 237d654..bc6f8f8 100644 > --- a/include/qemu-common.h > +++ b/include/qemu-common.h > @@ -157,7 +157,6 @@ int stristart(const char *str, const char *val, const char **ptr); > int qemu_strnlen(const char *s, int max_len); > char *qemu_strsep(char **input, const char *delim); > time_t mktimegm(struct tm *tm); > -int qemu_fls(int i); > int qemu_fdatasync(int fd); > int fcntl_setfl(int fd, int flag); > int qemu_parse_fd(const char *param); > diff --git a/util/cutils.c b/util/cutils.c > index 5d1c9eb..43aafde 100644 > --- a/util/cutils.c > +++ b/util/cutils.c > @@ -145,11 +145,6 @@ time_t mktimegm(struct tm *tm) > return t; > } > > -int qemu_fls(int i) > -{ > - return 32 - clz32(i); > -} > - > /* > * Make sure data goes on disk, but if possible do not bother to > * write out the inode just for timestamp updates. > Reviewed-by: Paolo Bonzini