Re: [Qemu-devel] [PATCH RFC 02/11] ide: necessary fields for ATAPI-SCSI bridge added

[Hannes Reinecke <hare@suse.de>]

On 08/18/2015 01:42 AM, Alexander Bezzubikov wrote:
> Signed-off-by: Alexander Bezzubikov <abezzubikov@ispras.ru>
> ---
>  hw/ide/internal.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/hw/ide/internal.h b/hw/ide/internal.h
> index f2999ce..3ebc63c 100644
> --- a/hw/ide/internal.h
> +++ b/hw/ide/internal.h
> @@ -429,6 +429,8 @@ struct IDEState {
>      uint8_t *smart_selftest_data;
>      /* AHCI */
>      int ncq_queues;
> +    /* ATAPI-SCSI bridge */
> +    SCSIRequest *cur_req;
>  };
>  
>  struct IDEDMAOps {
> @@ -493,6 +495,7 @@ struct IDEDevice {
>      char *serial;
>      char *model;
>      uint64_t wwn;
> +    SCSIBus *scsi_bus;
>  };
>  
>  /* These are used for the error_status field of IDEBus */
> 
Hmm. I would rather merge this with the patch where the
fields are used; as it stands it looks a bit pointless.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)