From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRqdv-0006Nr-7h for qemu-devel@nongnu.org; Tue, 18 Aug 2015 19:50:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZRqds-0005kh-1U for qemu-devel@nongnu.org; Tue, 18 Aug 2015 19:50:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRqdr-0005iy-SJ for qemu-devel@nongnu.org; Tue, 18 Aug 2015 19:50:07 -0400 Message-ID: <55D3C4A8.405@redhat.com> Date: Tue, 18 Aug 2015 16:50:00 -0700 From: Thomas Huth MIME-Version: 1.0 References: <1439854945-5597-1-git-send-email-abezzubikov@ispras.ru> <1439854945-5597-3-git-send-email-abezzubikov@ispras.ru> In-Reply-To: <1439854945-5597-3-git-send-email-abezzubikov@ispras.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC 02/11] ide: necessary fields for ATAPI-SCSI bridge added List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Bezzubikov , qemu-devel@nongnu.org Cc: jsnow@redhat.com, hare@suse.de, abezzubikov@ispras.ru On 17/08/15 16:42, Alexander Bezzubikov wrote: > Signed-off-by: Alexander Bezzubikov > --- > hw/ide/internal.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/ide/internal.h b/hw/ide/internal.h > index f2999ce..3ebc63c 100644 > --- a/hw/ide/internal.h > +++ b/hw/ide/internal.h > @@ -429,6 +429,8 @@ struct IDEState { > uint8_t *smart_selftest_data; > /* AHCI */ > int ncq_queues; > + /* ATAPI-SCSI bridge */ > + SCSIRequest *cur_req; Considering that you're extending struct *IDEState* here, I think the name "cur_req" might be a little bit misleading? Maybe rather name it "scsi_req" or "atapi_req"? Thomas