From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRqsy-00060b-5m for qemu-devel@nongnu.org; Tue, 18 Aug 2015 20:05:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZRqst-0003xI-I9 for qemu-devel@nongnu.org; Tue, 18 Aug 2015 20:05:42 -0400 Received: from mx2.parallels.com ([199.115.105.18]:38334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRqss-0003sy-NR for qemu-devel@nongnu.org; Tue, 18 Aug 2015 20:05:38 -0400 Message-ID: <55D3C4CB.5030002@openvz.org> Date: Tue, 18 Aug 2015 16:50:35 -0700 From: "Denis V. Lunev" MIME-Version: 1.0 References: <1439380232-20660-1-git-send-email-den@openvz.org> In-Reply-To: <1439380232-20660-1-git-send-email-den@openvz.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 for 2.5 0/3] Move target- and device specific code from monitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , Luiz Capitulino , qemu-devel@nongnu.org, Pavel Butsykin On 08/12/2015 04:50 AM, Denis V. Lunev wrote: > The monivation of this set is simple. Recently we have proposed patch > to monitor.c with specific x86 APIC HMP commands. The patchset was denied > with the main motivation "No more arch specific code in monitor.c" > This patchset is the first step to move arch specific code from > monitor.c targets. > > So, monitor.c already contains a lot of generic code, as well as the target > specifics code and eventually monitor.c volume will only grow. This trend leads > to a variety of fouling code ifdeffery(and combinations thereof), > poor readability, and entanglement of architecture of the project. > If someone wants to improve processing logic commands at the monitor, > it isn't necessarily must differentiate amongst the implementation of some ARM > or x86_64 specific commands, because the project already has separation of > target specific code on directories. > > The presented solution is not the best, but it is quite simple > (PATCH doesn't add more code!) and decides the above mentioned issue. > Subsequently it will not prevent the introduction of more advanced mechanism > that can more effectively resolve the issue. > > There is a issue with the placement of code for multiple architectures > (isn't for everyone), but this code is very small. This patch is a step towards > solving the issue associated with maintaining the purity of the code and > structure of the project, which solves not all, but doing a little better > than it is. > > Changes from v1: > - ported to new head > > Signed-off-by: Pavel Butsykin > Signed-off-by: Denis V. Lunev > CC: Luiz Capitulino > CC: Paolo Bonzini > CC: Peter Maydell > ping as per verbal discussion this stuff is intrusive and become rotten very soon. Can we at least discuss it at least to come into agreement about the approach. Den