From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRwMq-0007mq-Ra for qemu-devel@nongnu.org; Wed, 19 Aug 2015 01:56:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZRwMl-00087V-TY for qemu-devel@nongnu.org; Wed, 19 Aug 2015 01:56:56 -0400 Received: from mx2.suse.de ([195.135.220.15]:54206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRwMl-000871-Ms for qemu-devel@nongnu.org; Wed, 19 Aug 2015 01:56:51 -0400 References: <1439854945-5597-1-git-send-email-abezzubikov@ispras.ru> <1439854945-5597-3-git-send-email-abezzubikov@ispras.ru> <55D3C4A8.405@redhat.com> From: Hannes Reinecke Message-ID: <55D41AA0.5040209@suse.de> Date: Wed, 19 Aug 2015 07:56:48 +0200 MIME-Version: 1.0 In-Reply-To: <55D3C4A8.405@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC 02/11] ide: necessary fields for ATAPI-SCSI bridge added List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , Alexander Bezzubikov , qemu-devel@nongnu.org Cc: jsnow@redhat.com, abezzubikov@ispras.ru On 08/19/2015 01:50 AM, Thomas Huth wrote: > On 17/08/15 16:42, Alexander Bezzubikov wrote: >> Signed-off-by: Alexander Bezzubikov >> --- >> hw/ide/internal.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/hw/ide/internal.h b/hw/ide/internal.h >> index f2999ce..3ebc63c 100644 >> --- a/hw/ide/internal.h >> +++ b/hw/ide/internal.h >> @@ -429,6 +429,8 @@ struct IDEState { >> uint8_t *smart_selftest_data; >> /* AHCI */ >> int ncq_queues; >> + /* ATAPI-SCSI bridge */ >> + SCSIRequest *cur_req; >=20 > Considering that you're extending struct *IDEState* here, I think the > name "cur_req" might be a little bit misleading? Maybe rather name it > "scsi_req" or "atapi_req"? >=20 Good point. 'scsi_req' is a far better name. Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg GF: J. Hawn, J. Guild, F. Imend=C3=B6rffer, HRB 16746 (AG N=C3=BCrnberg)