Re: [Qemu-devel] [PATCH RFC v3 0/5] QEMU ATAPI-SCSI bridge GSoC project

[Hannes Reinecke <hare@suse.de>]

On 08/19/2015 12:57 PM, Alexander Bezzubikov wrote:
> This is my QEMU Google Summer of Code project.
> Here I introduce new device - ATAPI-SCSI bridge.
> Its purpose is to unify IDE ATAPI CD-ROM emulation
> with SCSI CD-ROM emulation to reduce code duplication and squash bugs.
> It's purpose is simple - it just forwards ATAPI commands
> to SCSI side for parsing and execution.
> 
> Example of using:
> qemu-system-x86_64 \
>         -drive if=none,file=<filename>,id=cdrom \
>         -drive if=none,id=fake \
>         -device ide-bridge,id=bridge,drive=fake \
>         -device scsi-cd,drive=cdrom,bus=bridge.0 \
>         -hda diskimage \
>         -m 1024
> 
> Alexander Bezzubikov (5):
>   ide: ATAPI-SCSI bridge TypeInfo and init function created
>   scsi: SCSIDiskReq declaration moved to header
>   ide: necessary checks corrected to treat ATAPI-SCSI bridge as CDROM
>   ATAPI-SCSI bridge functions created an can be used by bridge
>   ide: ATAPI-SCSI bridge transfer is treated as PIO
> 
>  hw/ide/Makefile.objs   |   2 +-
>  hw/ide/atapi.c         |  20 ++++++++-
>  hw/ide/bridge.c        | 114 +++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/ide/bridge.h        |  10 +++++
>  hw/ide/core.c          |  28 +++++++-----
>  hw/ide/internal.h      |   6 ++-
>  hw/ide/qdev.c          |  43 ++++++++++++++++++-
>  hw/scsi/scsi-disk.c    |  55 ++++++++++++++++++------
>  include/hw/scsi/scsi.h |  16 +++++++
>  9 files changed, 267 insertions(+), 27 deletions(-)
>  create mode 100644 hw/ide/bridge.c
>  create mode 100644 hw/ide/bridge.h
> 
I've just got a minor issue on patch 4/5 (rename cur_req to
scsi_req), other than that the patchset looks good.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)