From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: armbru@redhat.com, stefanha@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v2] hmp: Allow for error message hints on HMP
Date: Wed, 19 Aug 2015 08:25:29 -0700 [thread overview]
Message-ID: <55D49FE9.3030304@redhat.com> (raw)
In-Reply-To: <1439934507-10346-1-git-send-email-eblake@redhat.com>
On 18/08/2015 14:48, Eric Blake wrote:
> Commits 7216ae3d and d2828429 disabled some error message hints,
> all because a change to use modern error reporting meant that the
> hint would be output prior to the actual error. Fix this by making
> hints a first-class member of Error.
>
> For example, we are now back to the pleasant:
>
> $ qemu-system-x86_64 --nodefaults -S --vnc :0 --chardev null,id=,
> qemu-system-x86_64: --chardev null,id=,: Parameter 'id' expects an identifier
> Identifiers consist of letters, digits, '-', '.', '_', starting with a letter.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2015-08-19 15:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 21:48 [Qemu-devel] [PATCH v2] hmp: Allow for error message hints on HMP Eric Blake
2015-08-19 15:25 ` Paolo Bonzini [this message]
2015-08-19 16:30 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D49FE9.3030304@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).