From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZS5Fu-0006gI-7o for qemu-devel@nongnu.org; Wed, 19 Aug 2015 11:26:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZS5FC-00034d-RL for qemu-devel@nongnu.org; Wed, 19 Aug 2015 11:25:44 -0400 Received: from mail-pa0-x232.google.com ([2607:f8b0:400e:c03::232]:36839) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZS5FC-00034E-HZ for qemu-devel@nongnu.org; Wed, 19 Aug 2015 11:25:38 -0400 Received: by pawq9 with SMTP id q9so5443817paw.3 for ; Wed, 19 Aug 2015 08:25:36 -0700 (PDT) Sender: Paolo Bonzini References: <1439934507-10346-1-git-send-email-eblake@redhat.com> From: Paolo Bonzini Message-ID: <55D49FE9.3030304@redhat.com> Date: Wed, 19 Aug 2015 08:25:29 -0700 MIME-Version: 1.0 In-Reply-To: <1439934507-10346-1-git-send-email-eblake@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] hmp: Allow for error message hints on HMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: armbru@redhat.com, stefanha@redhat.com, afaerber@suse.de On 18/08/2015 14:48, Eric Blake wrote: > Commits 7216ae3d and d2828429 disabled some error message hints, > all because a change to use modern error reporting meant that the > hint would be output prior to the actual error. Fix this by making > hints a first-class member of Error. > > For example, we are now back to the pleasant: > > $ qemu-system-x86_64 --nodefaults -S --vnc :0 --chardev null,id=, > qemu-system-x86_64: --chardev null,id=,: Parameter 'id' expects an identifier > Identifiers consist of letters, digits, '-', '.', '_', starting with a letter. > > Signed-off-by: Eric Blake > --- Reviewed-by: Paolo Bonzini